Page MenuHome
Differential D2351

blender 2.8: OpenGL immediate mode: action_draw
ClosedPublic
Actions

Authored by Darwin Yip (darwin) on Nov 15 2016, 1:54 AM.

Details

Reviewers
Mike Erwin (merwin)
Commits
rBS093b6c9e6e8e: blender 2.8: OpenGL immediate mode: action_draw
rB093b6c9e6e8e: blender 2.8: OpenGL immediate mode: action_draw
Summary

Updated action_draw to use imm mode.

Diff Detail

Repository
rB Blender

Event Timeline

Darwin Yip (darwin) updated this revision to Diff 7791.Nov 15 2016, 1:54 AM
Darwin Yip (darwin) retitled this revision from to blender 2.8: OpenGL immediate mode: action_draw.
Darwin Yip (darwin) updated this object.
Darwin Yip (darwin) set the repository for this revision to rB Blender.
Ray Molenkamp (LazyDodo) added a reviewer: Mike Erwin (merwin).Nov 15 2016, 1:56 AM
Ray Molenkamp (LazyDodo) added a subscriber: Ray Molenkamp (LazyDodo).

related to T49043

Mike Erwin (merwin) edited edge metadata.Nov 15 2016, 2:01 AM

Welcome!

I can see a few problems. Gawain (new drawing API) will catch lots of these in debug builds:

make lite debug (Mac or Linux)
or
make 2015 lite debug (Windows + Visual Studio 2015)

Then run and it will tell you where the problem is.

Mike Erwin (merwin) added a comment.Nov 15 2016, 2:02 AM

immAttrib4ub can only be called between immBegin & immEnd for example

Darwin Yip (darwin) updated this revision to Diff 7793.Nov 15 2016, 3:33 AM
Darwin Yip (darwin) edited edge metadata.

Use immUniform rather than immAttrib for calls outside of immBegin and immEnd. Also caught some calls that were missed earlier.

Darwin Yip (darwin) updated this revision to Diff 7794.Nov 15 2016, 4:13 AM

Missed the bindings.

Mike Erwin (merwin) added a comment.Nov 15 2016, 4:17 AM

This is looking good. Are you done or is there more coming?

Darwin Yip (darwin) added a comment.Nov 15 2016, 4:19 AM

Done for this file. Please let me know if any improvements can be done or if I missed anything.

Mike Erwin (merwin) added inline comments.Nov 15 2016, 4:28 AM
source/blender/editors/space_action/action_draw.c
243–252

These 4 lines have an extra space after the ;

Not sure if it was there before your change. Either way this is a good opportunity to fix it :)

Mike Erwin (merwin) mentioned this in D2352: T49043: Replace OpenGL immediate mode in Blender 2.8 (action_draw.c).Nov 15 2016, 4:33 AM
Darwin Yip (darwin) updated this revision to Diff 7795.Nov 15 2016, 4:48 AM

Removed trailing spaces.

Mike Erwin (merwin) accepted this revision.Nov 15 2016, 5:04 AM
Mike Erwin (merwin) edited edge metadata.
This revision is now accepted and ready to land.Nov 15 2016, 5:04 AM
Mike Erwin (merwin) closed this revision.Nov 15 2016, 5:04 AM

Landed in blender2.8. Thanks!

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_action/
66 lines

Diff 7795

View Options

source/blender/editors/space_action/action_draw.c

Loading...