Page MenuHome

blender 2.8: OpenGL immediate mode: anim_draw
ClosedPublic

Authored by Punya Biswal (punya) on Nov 15 2016, 5:21 AM.

Diff Detail

Repository
rB Blender

Event Timeline

Punya Biswal (punya) retitled this revision from to blender 2.8: OpenGL immediate mode: anim_draw.
Punya Biswal (punya) updated this object.
Punya Biswal (punya) set the repository for this revision to rB Blender.

Used immUniform instead of creating a new utility.

source/blender/editors/animation/anim_draw.c
101

This calls glColor indirectly, so must be changed. You can use immUniformThemeColorShade after binding GPU_SHADER_2D_UNIFORM_COLOR.

176

Since you're using uniform color, do this once after immBind...

immUniformColor4f(0.0f, 0.0f, 0.0f, 0.4f);

Then call immRectf below.

source/blender/editors/animation/anim_draw.c
163

We were thinking the same thing!

Now this color attribute is not needed.

Punya Biswal (punya) marked 2 inline comments as done.

Addressed comments except those pertaining to UI_ThemeColorShade.

Fix UI_ThemeColorShade issue.

Punya Biswal (punya) marked an inline comment as done.Nov 15 2016, 5:56 AM

I addressed all your comments (I think!).

Almost done!

source/blender/editors/animation/anim_draw.c
134

immUniformThemeColor(TH_CFRAME);

here instead of

UI_ThemeColor(TH_CFRAME);

above.

Punya Biswal (punya) edited edge metadata.
Punya Biswal (punya) marked an inline comment as done.

Addressed remaining use of UI_ThemeColor

Addressed remaining use of UI_ThemeColor.

Mike Erwin (merwin) edited edge metadata.
This revision is now accepted and ready to land.Nov 15 2016, 6:16 PM

Landed in blender2.8