Page MenuHome
Differential D2364

Replacing UI_view2d_scrollsers_draw() to immedaite mode
ClosedPublic
Actions

Authored by Benjamin Summerton (define-private-public) on Nov 18 2016, 4:28 AM.

Details

Reviewers
Mike Erwin (merwin)
Anthony Edlin (krash)
Maniphest Tasks
T49043: replace OpenGL immediate mode in Blender 2.8
Commits
rBSe369b85e2f06: Replacing UI_view2d_scrollsers_draw() to immedaite mode
rBe369b85e2f06: Replacing UI_view2d_scrollsers_draw() to immedaite mode
Summary

Part of T49043

Diff Detail

Repository
rB Blender
Branch
imm.view2d.c.UI_view2d_scrollers_draw
Build Status
Buildable 297
Build 297: arc lint + arc unit

Event Timeline

Benjamin Summerton (define-private-public) updated this revision to Diff 7835.Nov 18 2016, 4:28 AM
Benjamin Summerton (define-private-public) retitled this revision from to Replacing UI_view2d_scrollsers_draw() to immedaite mode.
Benjamin Summerton (define-private-public) updated this object.
Benjamin Summerton (define-private-public) updated this revision to Diff 7840.Nov 18 2016, 5:02 AM
  • Horizontal scrolbars now use immedaite mode
  • vertical scrollbars now use immediate mode
Benjamin Summerton (define-private-public) added reviewers: Mike Erwin (merwin), Anthony Edlin (krash).Nov 18 2016, 5:07 AM

Please review this. Please give me a response for the comment at line 1765.

source/blender/editors/interface/view2d.c
1811–1812

This seems a little odd to me that we would draw the scrollbars if and only if the alpha channel is fully visible. Shouldn't it be col[3] != 0? Or do we want to leave it like this.

Same goes for line 1873

Mike Erwin (merwin) edited edge metadata.Nov 18 2016, 5:15 AM

Would be better to get TH_BACK only once in this function.

source/blender/editors/interface/view2d.c
1811–1812

From the comment above this clears a rect behind the scrollers. If not opaque it lets the existing pixels show through.

Benjamin Summerton (define-private-public) updated this revision to Diff 7842.Nov 18 2016, 7:37 AM
Benjamin Summerton (define-private-public) edited edge metadata.
  • only grabs color once now.
Benjamin Summerton (define-private-public) updated this object.Nov 18 2016, 9:40 PM
Mike Erwin (merwin) added inline comments.Nov 20 2016, 10:19 PM
source/blender/editors/interface/view2d.c
1779–1781

I recommend getting rid of these. See below...

1813–1814

unsigned pos = add_attrib(immVertexFormat(), "pos" ...

1919–1920

same here

Benjamin Summerton (define-private-public) updated this revision to Diff 7864.Nov 21 2016, 1:23 AM
Benjamin Summerton (define-private-public) marked 2 inline comments as done.
  • Merge branch 'blender2.8' into imm.view2d.c.UI_view2d_scrollers_draw
  • Merge branch 'blender2.8' into imm.view2d.c.UI_view2d_scrollers_draw
  • small cleanup
Mike Erwin (merwin) accepted this revision.Nov 21 2016, 7:03 PM
Mike Erwin (merwin) edited edge metadata.
This revision is now accepted and ready to land.Nov 21 2016, 7:03 PM
Anthony Edlin (krash) accepted this revision.Nov 22 2016, 5:36 PM
Anthony Edlin (krash) edited edge metadata.

Built and tested, seems fine.

Benjamin Summerton (define-private-public) updated this object.Nov 24 2016, 5:13 AM
Benjamin Summerton (define-private-public) edited edge metadata.
Mike Erwin (merwin) closed this revision.Nov 29 2016, 2:14 AM

landed in blender2.8

Mike Erwin (merwin) added a task: T49043: replace OpenGL immediate mode in Blender 2.8.Nov 29 2016, 2:14 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
34 lines

Diff 7864

View Options

source/blender/editors/interface/view2d.c

Loading...