Page MenuHome
Differential D2366

Change CMake rules when building Cycles (standalone) in debug mode
AbandonedPublic
Actions

Authored by Bojian Wu (boj) on Nov 18 2016, 5:10 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Martijn Berger (juicyfruit)
Summary

Actually, I try to build Cycles (standalone) on Windows 10 with Microsoft Visual Studio 2013, but in debug mode, it fails to link OpenImageIO and OpenEXR related libraries (mixed utilization of libraries of debug/release mode), so I make a minor change of CMake rules.

Diff Detail

Repository
rC Cycles

Event Timeline

Bojian Wu (boj) updated this revision to Diff 7847.Nov 18 2016, 5:10 PM
Bojian Wu (boj) retitled this revision from to Change CMake rules when building Cycles (standalone) in debug mode.
Bojian Wu (boj) updated this object.
Bojian Wu (boj) set the repository for this revision to rC Cycles.
Bojian Wu (boj) added a project: Cycles.
Martijn Berger (juicyfruit) added a subscriber: Martijn Berger (juicyfruit).Nov 18 2016, 5:28 PM

Looks good to me except from some minor style things which are subjective

src/cmake/Modules/FindOpenEXR.cmake
125

I think it would look nicer with some new lines to break this up

148

same as above

Bojian Wu (boj) updated this revision to Diff 7856.Nov 19 2016, 5:32 PM
Bojian Wu (boj) added a reviewer: Martijn Berger (juicyfruit).

Thanks @Martijn Berger (juicyfruit), I have made some changes about my patch with your opinions, please review.

Aaron Carlisle (Blendify) added a reviewer: Sergey Sharybin (sergey).Feb 11 2017, 7:47 PM
Aaron Carlisle (Blendify) abandoned this revision.Jul 23 2017, 8:06 PM
Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).

This should work fine now with latest master.

Revision Contents
Changeset List

PathSize
src/
cmake/
Modules/
14 lines
18 lines

Diff 7847

View Options

src/cmake/Modules/FindOpenEXR.cmake

Loading...
View Options

src/cmake/Modules/FindOpenImageIO.cmake

Loading...