Page MenuHome
Differential D2373

OpenGL: updated keyframes_draw.c to new immediate mode
AbandonedPublic
Actions

Authored by Darwin Yip (darwin) on Nov 21 2016, 5:24 AM.

Details

Reviewers
Mike Erwin (merwin)
Maniphest Tasks
T49043: replace OpenGL immediate mode in Blender 2.8
Summary

Just as mentioned at the title.

T49043

Diff Detail

Repository
rB Blender

Event Timeline

Darwin Yip (darwin) updated this revision to Diff 7867.Nov 21 2016, 5:24 AM
Darwin Yip (darwin) retitled this revision from to OpenGL: updated keyframes_draw.c to new immediate mode.
Darwin Yip (darwin) updated this object.
Darwin Yip (darwin) added a reviewer: Mike Erwin (merwin).
Darwin Yip (darwin) set the repository for this revision to rB Blender.
Darwin Yip (darwin) added a project: BF Blender: 2.8.
Darwin Yip (darwin) updated this object.
Mike Erwin (merwin) added inline comments.Nov 21 2016, 5:39 AM
source/blender/editors/animation/keyframes_draw.c
485–519

All this display list code should go away. That's an obsolete OpenGL feature.

568–569

Can shorten each of these lines:
immUniformThemeColor(sel ? TH_KEYTYPE_EXTREME_SELECT : TH_KEYTYPE_EXTREME);

594

delete, keep same program bound

597–599

delete

608–610

delete

615

delete

621

delete (old OpenGL feature)

630

Move this to after this "if" block, near the end of the function.

632

delete

680

bind a shader for drawing

689

Can shorten these: immUniformColor4fv(ab->sel ? sel_mhcol : unsel_mhcol);

Darwin Yip (darwin) updated this revision to Diff 7926.Dec 2 2016, 2:49 AM

Addressed issues.

Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).Jan 16 2017, 4:41 PM

@Mike Erwin (merwin) poke, is this already ready to master?

Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).Jan 16 2017, 4:41 PM

@Mike Erwin (merwin) Could you take a look of this review?

I'm working in adding palettes to dope sheet for 2.8 and I'm having problems with glLists, and this patch fix this problem.

Dalai Felinto (dfelinto) added a task: T49043: replace OpenGL immediate mode in Blender 2.8.Jan 16 2017, 4:42 PM
Mike Erwin (merwin) edited edge metadata.Jan 19 2017, 9:12 AM

@Dalai Felinto (dfelinto),@Antonio Vazquez (antoniov) No, it's not ready. I'm investigating ways to do this right.

To update this patch from my end, can I just "arc patch", make changes, then "arc diff"?

Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).Jan 19 2017, 9:37 AM

@Mike Erwin (merwin) you’ll have to commandeer the revision first (in phabbricator web interface). :)

Mike Erwin (merwin) abandoned this revision.Feb 11 2017, 6:34 AM

This work made it into blender2.8 as part of a larger keyframe drawing overhaul. Thanks!

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
animation/
99 lines

Diff 7926

View Options

source/blender/editors/animation/keyframes_draw.c

Loading...