Fixed incorrect uniform export
ClosedPublic
Actions

Authored by Michael Stahre (MichaelStahre) on Nov 24 2016, 2:41 PM.

Details

Reviewers

Commits

rBS7f10a889e33c: Fix incorrect spot lamp blend in python GPU uniform export.
rB7f10a889e33c: Fix incorrect spot lamp blend in python GPU uniform export.

Summary

Instead of exporting GPU_DYNAMIC_LAMP_SPOTSIZE and then GPU_DYNAMIC_LAMP_SPOTBLEND, GPU_DYNAMIC_LAMP_SPOTSIZE was exported twice, this fixes that.

Diff Detail

Repository: rB Blender

Event Timeline

Michael Stahre (MichaelStahre) updated this revision to Diff 7880.Nov 24 2016, 2:41 PM

Michael Stahre (MichaelStahre) retitled this revision from to Fixed incorrect uniform export.

Michael Stahre (MichaelStahre) updated this object.

Michael Stahre (MichaelStahre) set the repository for this revision to rB Blender.

Michael Stahre (MichaelStahre) added a project: BF Blender.

Michael Stahre (MichaelStahre) mentioned this in D2379: Exposed missing uniform type constant to python.Nov 24 2016, 2:44 PM

Sebastian Ullrich (souljedi) added a subscriber: Sebastian Ullrich (souljedi).Jan 24 2017, 5:17 PM

This and D2379 are two followups to a commit i made a year ago D1475. Would be great if they could be reviewed soon, we plan to make more contributions to the Blender X3D exporter...

Brecht Van Lommel (brecht) accepted this revision.Feb 2 2017, 4:16 AM

Brecht Van Lommel (brecht) edited edge metadata.

This revision is now accepted and ready to land.Feb 2 2017, 4:16 AM

Thanks for the fixes, I'll commit.

Closed by commit rB7f10a889e33c: Fix incorrect spot lamp blend in python GPU uniform export. (authored by Michael Stahre (MichaelStahre), committed by Brecht Van Lommel (brecht)). · Explain WhyFeb 2 2017, 4:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

intern/

gpu_material.c

2 lines

Diff 8225

View Options

source/blender/gpu/intern/gpu_material.c

Fixed incorrect uniform exportClosedPublicActions