References T50112
Stop blender crashing if a scene from a loaded file specifies SEQ_USE_PROXY and proxy struct was not loaded from the .blend file.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
| source/blender/blenloader/intern/readfile.c | ||
|---|---|---|
| 6005 | Don't think this is right, (or at least take care changing this). If the users wants their sequence to use a proxy, file loading shouldb't be disabling this. Instead it could crate the proxy struct if thats whats needed. | |
| source/blender/blenloader/intern/readfile.c | ||
|---|---|---|
| 6005 | You're right, however I think the ticket and original description is probably muddying the waters a bit... if you load a file with proxy enabled having e.g. deleted the BL_proxy data, this code is not hit as the proxy struct is still loaded correctly from the file, and the proxy flag remains set for when the user regenerates the proxy data. In the file in T50112, the proxy struct itself is not loaded (why? previous version of file? just plain corrupted by a crash?) so we cannot know what the proxy settings were. Not sure how often this will occur - if it's a corrupt file then probably not that often, and making it at least possible to continue without a crash might be the best we can do. The same of course might be said for any line in that file that uses a struct without checking to see if it's NULL first... | |