Differential D2391

OpenGL: updated clip_utils.c to new immediate mode
ClosedPublic
Actions

Authored by Darwin Yip (darwin) on Dec 2 2016, 3:59 AM.

Tags

Subscribers

None

Details

Reviewers

Mike Erwin (merwin)

Maniphest Tasks

T49043: replace OpenGL immediate mode in Blender 2.8

Summary

Updated clip_utils.c

Diff Detail

Repository: rB Blender

Event Timeline

Darwin Yip (darwin) updated this revision to Diff 7927.Dec 2 2016, 3:59 AM

Darwin Yip (darwin) retitled this revision from to OpenGL: updated clip_utils.c to new immediate mode.

Darwin Yip (darwin) updated this object.

Darwin Yip (darwin) added a reviewer: Mike Erwin (merwin).

Darwin Yip (darwin) set the repository for this revision to rB Blender.

Darwin Yip (darwin) added a project: BF Blender: 2.8.

Dalai Felinto (dfelinto) added a task: T49043: replace OpenGL immediate mode in Blender 2.8.Jan 16 2017, 4:48 PM

Dalai Felinto (dfelinto) mentioned this in D2369: OpenGL: updated clip_utils.c to new immediate mode.Jan 16 2017, 4:52 PM

Mike Erwin (merwin) added inline comments.Jan 16 2017, 6:22 PM

source/blender/editors/space_clip/clip_utils.c
254	This line is black instead of green. Pull these lines down so they affect the bound shader: /* Draw a light green line to indicate current frame */ UI_ThemeColor(TH_CFRAME); Just change UI_ThemeColor to immUniformThemeColor.
295	fdrawline below can also be updated. immBegin(GL_LINES, 4) ... Keep GPU_SHADER_2D_UNIFORM_COLOR bound, just update the color with immUniformThemeColorShade. Also noticed these lines need a glLineWidth(1.0f).

Addressed color line issue and updated deprecated functions to use imm.

Works fine now! See final commit for some small changes I made.

This revision is now accepted and ready to land.Feb 11 2017, 6:42 AM

Committed to blender2.8

Mike Erwin (merwin) mentioned this in rBe008ca13f138: OpenGL: updated clip_utils.c to new immediate mode.Feb 11 2017, 7:00 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_clip/

49 lines

Diff 8157

source/blender/editors/space_clip/clip_utils.c

Loading...