Compositor: Make HSV node inputs a real sockets
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Dec 7 2016, 1:54 PM.

Details

Reviewers

Bastien Montagne (mont29)
Brecht Van Lommel (brecht)
Dalai Felinto (dfelinto)

Commits

rBSac58a7fa190d: Compositor: Make HSV node inputs a real sockets
rBac58a7fa190d: Compositor: Make HSV node inputs a real sockets

Summary

This is much more flexible solution with the only downside of
compatibility issues.

Diff Detail

Repository

rB Blender

Branch

compo_hsv

Build Status

Buildable 406
Build 406: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) updated this revision to Diff 7949.Dec 7 2016, 1:54 PM

Sergey Sharybin (sergey) retitled this revision from to Compositor: Make HSV node inputs a real sockets.

Sergey Sharybin (sergey) added reviewers: Brecht Van Lommel (brecht), Dalai Felinto (dfelinto), Bastien Montagne (mont29).

Sergey Sharybin (sergey) updated this object.

I think someone said recently that we should end only having sockets for nodes… ;)

From quick reading patch LGTM, but am not a specialist of compositor or nodes.

Regarding after-liblinking do_versions: iirc @Dalai Felinto (dfelinto) or @Julian Eisel (Severin) are also needing that in their branch (re layers/workspaces)… In any case, I see no reason not to resurrect do_versions_after_linking(), kincking out dead 2.5 anim code update of course… Not sure what was crashing here at that time, but I can't see any reason why this would not be valid step in readfile process?

This revision is now accepted and ready to land.Dec 7 2016, 3:10 PM

Indeed it would be nice to have a do_versions function after lib linking. For workspaces I simply did the conversion in lib_link_foo but that's ugly. Rather have a proper place for this. (Can we move all the do_versions stuff to a phase after lib linking? What is the issue with that? The animation code @Bastien Montagne (mont29) mentioned?)

The issue with that would be that linking happens after all bmains were merged. Meaning, if you'll have libraries saved with different blender version your versioning code would be confused.

Think we can work around that issue pretty easily:

we keep all non-ID-related versionning before merging mains (that is 99% of versionning needs), as it is currently.
we store .blend versions in Library datablocks at read time, that way post-linking versionning code can still access version data of current linked datablocks.

Bastien Montagne (mont29) mentioned this in D2422: Add do_versions_after_liblink() to read code.Dec 19 2016, 8:18 PM

After-linking do_version is now possible, so patch needs updates ;)

This revision now requires changes to proceed.Jan 9 2017, 12:27 PM

Add proper do_versions after linking

Sergey Sharybin (sergey) updated this object.Jan 18 2017, 12:56 PM

Sergey Sharybin (sergey) edited edge metadata.

Besides minor cleanup points noted below, versionning code LGTM (will trust you on node code itself).

source/blender/blenloader/intern/readfile.c
8395–8396	To be removed, `main` is used now! ;)
source/blender/blenloader/intern/versioning_270.c
203	Agree - but we can do that outside of this patch as well.
230–231	to be removed now