Updates to outliner_draw_highlights_recursive under the blender2.8 branch
ClosedPublic
Actions

Authored by Chaitanya (cyrax) on Dec 25 2016, 2:12 AM.

Details

Reviewers

Maniphest Tasks

T49043: replace OpenGL immediate mode in Blender 2.8

Summary

Isolated to just outliner_draw_highlights_recursive in the outliner_draw.c
Other function updates will be in their own diffs.

Diff Detail

Repository: rB Blender

Event Timeline

Chaitanya (cyrax) updated this revision to Diff 8038.Dec 25 2016, 2:12 AM

Chaitanya (cyrax) retitled this revision from to Updates to outliner_draw_highlights_recursive under the blender2.8 branch.

Chaitanya (cyrax) updated this object.

Chaitanya (cyrax) added a reviewer: Mike Erwin (merwin).

Chaitanya (cyrax) set the repository for this revision to rB Blender.

Chaitanya (cyrax) updated this revision to Diff 8040.Dec 27 2016, 4:20 AM

Chaitanya (cyrax) removed rB Blender as the repository for this revision.

Chaitanya (cyrax) added a project: BF Blender: 2.8.

Generating a commit that included the original diff but excluded the changes to outliner_draw_struct_marks

Chaitanya (cyrax) set the repository for this revision to rB Blender.Dec 27 2016, 6:44 AM

Some code looks indented too much, but overall looks good!

Updated with formatting changes. Seems Netbeans is expanding tabs. Checked in vim.

Mike Erwin (merwin) added a task: T49043: replace OpenGL immediate mode in Blender 2.8.Feb 7 2017, 5:42 PM

Mike Erwin (merwin) accepted this revision.Feb 7 2017, 6:48 PM

Mike Erwin (merwin) edited edge metadata.

This revision is now accepted and ready to land.Feb 7 2017, 6:48 PM

@Chaitanya (cyrax), I'm trying to commit this to blender2.8 under your name.

What full name and email do you use with git?

For example mine is "Mike Erwin <significant.bit@gmail.com>"

@Chaitanya (cyrax) do you use "arc diff" to submit these?

For some reason patches by @Benjamin Summerton (define-private-public) are landed with his name. Arcanist loses most people's names. Maybe he knows the secret?

@Mike Erwin (merwin) I commit code under "Cyrax <cyrax.iiit@gmail.com>"

I've been submitting patches through the website. Don't think arcanist does anything special. It translates to a git diff and a patch.

Mike Erwin (merwin) mentioned this in rB525937cc397e: OpenGL: outliner_draw_highlights uses new imm mode.Feb 8 2017, 8:39 PM

It worked! Pushed to blender2.8

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_outliner/

outliner_draw.c

26 lines

Diff 8042

View Options

source/blender/editors/space_outliner/outliner_draw.c

Updates to outliner_draw_highlights_recursive under the blender2.8 branchClosedPublicActions