Differential D2434

Updating outliner_draw_struct_marks to retained mode
ClosedPublic
Actions

Authored by Chaitanya (cyrax) on Dec 27 2016, 2:56 AM.

Tags

Subscribers

None

Details

Reviewers

Mike Erwin (merwin)

Maniphest Tasks

T49043: replace OpenGL immediate mode in Blender 2.8

Commits

rBS4e2c6ad8eeef: Updating outliner_draw_struct_marks to retained mode
rB4e2c6ad8eeef: Updating outliner_draw_struct_marks to retained mode

Summary

Had to add a few utility functions to replace existing functions. Let me know if these are duplicates.

Diff Detail

Repository: rB Blender

Event Timeline

Chaitanya (cyrax) updated this revision to Diff 8039.Dec 27 2016, 2:56 AM

Chaitanya (cyrax) retitled this revision from to Updating outliner_draw_struct_marks to retained mode.

Chaitanya (cyrax) updated this object.

Chaitanya (cyrax) added a reviewer: Mike Erwin (merwin).

Chaitanya (cyrax) set the repository for this revision to rB Blender.

Chaitanya (cyrax) added a project: BF Blender: 2.8.

Hi, thanks for contributing! Here are some simple comments. I'll take a closer look at this tomorrow.

source/blender/editors/interface/resources.c
1328	Indention here & a few other places needs cleanup.
source/blender/editors/screen/glutil.c
216–223	I think drawing one line is so simple that no helper function is needed. fdrawline will just go away.
source/blender/editors/space_outliner/outliner_draw.c
1684–1691	blender code style if (condition) { do stuff; }

Mike Erwin (merwin) added a task: T49043: replace OpenGL immediate mode in Blender 2.8.Dec 27 2016, 6:52 AM

Updated the formatting. I'd like to keep the draw line function around. Makes is look cleaner.

Chaitanya (cyrax) marked 2 inline comments as done.Dec 27 2016, 9:48 AM

Chaitanya (cyrax) added inline comments.

source/blender/editors/screen/glutil.c
216–223	Left this in place. If there are strong feelings against this kind of util functions, let me know and I'll delete it. Otherwise it helps reduce clutter.
source/blender/editors/space_outliner/outliner_draw.c
1697	Is there a better way to do this? Perhaps change the input format from INT to FLOAT and use immRectf; thus avoiding multiple bindings. I am not sure if we should be updating the signature of this function as yet.

Mike Erwin (merwin) accepted this revision.Jan 16 2017, 1:29 AM

Mike Erwin (merwin) edited edge metadata.

This revision is now accepted and ready to land.Jan 16 2017, 1:29 AM

Landed in blender2.8 — thanks!

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

include/

1 line

4 lines

interface/

21 lines

screen/

12 lines

space_outliner/

outliner_draw.c

24 lines

gpu/

GPU_immediate.h

2 lines

intern/

gpu_immediate.c

8 lines

Diff 8043

source/blender/editors/include/BIF_glutil.h

Loading...

source/blender/editors/include/UI_resources.h

Loading...

source/blender/editors/interface/resources.c

Loading...

source/blender/editors/screen/glutil.c

Loading...

source/blender/editors/space_outliner/outliner_draw.c

Loading...

source/blender/gpu/GPU_immediate.h

Loading...

source/blender/gpu/intern/gpu_immediate.c

Loading...