Differential D2438

Updates the tree element to use retained mode
ClosedPublic
Actions

Authored by Chaitanya (cyrax) on Dec 28 2016, 10:11 AM.

Tags

Subscribers

None

Details

Reviewers

Mike Erwin (merwin)

Maniphest Tasks

T49043: replace OpenGL immediate mode in Blender 2.8

Diff Detail

Repository: rB Blender

Event Timeline

Chaitanya (cyrax) updated this revision to Diff 8050.Dec 28 2016, 10:11 AM

Chaitanya (cyrax) retitled this revision from to Updates the tree element to use retained mode.

Chaitanya (cyrax) updated this object.

Chaitanya (cyrax) added a reviewer: Mike Erwin (merwin).

Chaitanya (cyrax) set the repository for this revision to rB Blender.

Chaitanya (cyrax) added a project: BF Blender: 2.8.

Chaitanya (cyrax) added inline comments.Dec 28 2016, 10:21 AM

source/blender/editors/space_outliner/outliner_draw.c
1602	Let me know if this is not a recommended style. The recursive function is fairly long and I wanted to make sure this section is discrete without having to create another function just for rendering a rectangle.

Mike Erwin (merwin) added a task: T49043: replace OpenGL immediate mode in Blender 2.8.Feb 7 2017, 5:45 PM

Mike Erwin (merwin) added inline comments.Feb 8 2017, 9:13 PM

source/blender/editors/interface/resources.c
1280–1282	nice!
source/blender/editors/space_outliner/outliner_draw.c
1602	No problem with the style. I've seen this in other places and use it myself to manage scope.

Mike Erwin (merwin) accepted this revision.Feb 9 2017, 12:29 AM

Mike Erwin (merwin) edited edge metadata.

This revision is now accepted and ready to land.Feb 9 2017, 12:29 AM

Mike Erwin (merwin) mentioned this in rB6444ba263529: added UI_GetThemeColorShade4ubv function.Feb 9 2017, 12:38 AM

Mike Erwin (merwin) mentioned this in rBf2ea319316f8: OpenGL: outliner_draw_tree_element uses new imm mode.

Pushed to blender2.8. Thanks!

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

include/

1 line

interface/

34 lines

space_outliner/

outliner_draw.c

19 lines

Diff 8050

source/blender/editors/include/UI_resources.h

Loading...

source/blender/editors/interface/resources.c

Loading...

source/blender/editors/space_outliner/outliner_draw.c

Loading...