Page MenuHome
Differential D2448

proposed fix for T50352
AbandonedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jan 4 2017, 10:31 PM.

Details

Reviewers
Bastien Montagne (mont29)
Dalai Felinto (dfelinto)
Summary

3D-printing check for distorted faces could fail with flipped normals

Diff Detail

Event Timeline

Philipp Oeser (lichtwerk) updated this revision to Diff 8079.Jan 4 2017, 10:31 PM
Philipp Oeser (lichtwerk) retitled this revision from to proposed fix for T50352.
Philipp Oeser (lichtwerk) updated this object.
Philipp Oeser (lichtwerk) set the repository for this revision to rBA Blender Add-ons.
Philipp Oeser (lichtwerk) mentioned this in T50352: 3D-printing check misinterprates flat ngons as non-flat.Jan 4 2017, 10:39 PM
Philipp Oeser (lichtwerk) added a comment.EditedJan 4 2017, 10:52 PM

this is what Mesh-Analysis (statvis) does: statvis_calc_distort() -- just to reference corresponding code for detecting non-flat faces that doesnt mark the faces from T50352: 3D-printing check misinterprates flat ngons as non-flat as non-flat...

Philipp Oeser (lichtwerk) added reviewers: Dalai Felinto (dfelinto), Bastien Montagne (mont29).Jan 5 2017, 10:02 AM

mind having a look if this is a feasable fix? thanx in advance!

Bastien Montagne (mont29) accepted this revision.Jan 10 2017, 5:30 PM
Bastien Montagne (mont29) edited edge metadata.

LGTM, do you have commit rights on rBA?

This revision is now accepted and ready to land.Jan 10 2017, 5:30 PM
Philipp Oeser (lichtwerk) added a comment.Jan 11 2017, 4:08 PM

@Bastien Montagne (mont29): yep, rBA is fine, can commit this when I'm back...

Philipp Oeser (lichtwerk) abandoned this revision.Jan 26 2018, 2:28 PM

commited long ago rBA8c06e5c7d98d2dea9b668bffc95606843c1746dc

Revision Contents
Changeset List

PathSize
object_print3d_utils/
5 lines

Diff 8079

View Options

object_print3d_utils/operators.py

Loading...