Page MenuHome

UI: improve the multicam strip UI
ClosedPublic

Authored by Aaron Carlisle (Blendify) on Jan 15 2017, 7:27 AM.

Details

Summary

Idea from https://rightclickselect.com/p/sequencer/zfbbbc/sequencer-panels-update by @Paulo José Oliveira Amaro (pauloup)

NOTE: This patch also removes the play button in the panel. I do not see a need for this when we have the time line editor, which is a must for video editing, and the keyboard shortcut.
AfterBefore

Test file:

Diff Detail

Repository
rB Blender

Event Timeline

Aaron Carlisle (Blendify) retitled this revision from to UI: improve the multicam strip UI.
Aaron Carlisle (Blendify) updated this object.
Aaron Carlisle (Blendify) set the repository for this revision to rB Blender.
Aaron Carlisle (Blendify) updated this object.
Julian Eisel (Severin) requested changes to this revision.Jan 15 2017, 7:19 PM
Julian Eisel (Severin) edited edge metadata.
Julian Eisel (Severin) added inline comments.
release/scripts/startup/bl_ui/space_sequencer.py
667–668

I'm not really familiar how multicam strip works, but it's a bit weird that there are no buttons other than the "Source Channel" one until the strip is moved to channel 3 or higher. There should be some hint to why nothing is shown when the strip is on channel 1 or 2.
Also note that the old code shows the cut_multicam button for channel 1 if the strip is on channel 2.

675

I don't think PEP8 has strict rules here, but usually we don't add parentheses around single line if-statements.

For this specific case, I suggest to reformat this to:
if (i % BT_ROW) == 1:

685

Would remove the (strip.channel > BT_ROW) check here to avoid jumps in layout.

690

The empty operator-buttons feel a bit weird, we usually don't have something like that in Blender. I'd just change this to row.label() to add placeholder elements.
(You can also remove the sub setup above then.)

Note that this will solve the issue mentioned in the description (which only appeared with Region Overlap enabled). The operator-buttons invoked the sequencer.cut_multicam operator which allowed the event to pass through if no index was specified, just like here. When Region Overlap is enabled, we allow handlers from the main region to listen to events from the properties/toolshelf regions (if they haven't been caught by panel, button or operator handling) because these can be fully transparent. That's why the mouse-click invokes a operation in the main region, even if executed in properties region.

This revision now requires changes to proceed.Jan 15 2017, 7:19 PM
Aaron Carlisle (Blendify) edited edge metadata.

Address some review points and code cleanup

Aaron Carlisle (Blendify) marked 2 inline comments as done.Jan 16 2017, 12:04 AM
Aaron Carlisle (Blendify) added inline comments.
release/scripts/startup/bl_ui/space_sequencer.py
685

I like having the layout always fill the width off the sidebar, this makes things more consistent.

Note that this patch also removes the play button. Any video editor should have the time line and they always have the keyboard shortcut.

Aaron Carlisle (Blendify) edited edge metadata.

If statement formatting

Julian Eisel (Severin) edited edge metadata.

Looks almost good to me, just 2 minor remarks.

release/scripts/startup/bl_ui/space_sequencer.py
681

Better use parentheses for readability: if strip.channel > BT_ROW and (strip_channel - 1) % BT_ROW:

686

Would get rid of the term "Warning" here, the info icon should be enough.

This revision is now accepted and ready to land.Feb 10 2017, 4:32 PM