Page MenuHome
Differential D2477

CMake: Remove MOTO library dependency when it is not needed.
ClosedPublic
Actions

Authored by Jorge Bernal (lordloki) on Jan 24 2017, 10:06 PM.

Details

Reviewers
Bastien Montagne (mont29)
Sergey Sharybin (sergey)
Commits
rBSdbdc346e9ff6: CMake: Remove MOTO library dependency when it is not needed
rBdbdc346e9ff6: CMake: Remove MOTO library dependency when it is not needed
Summary

It is not necessary to add MOTO library dependency when we use WITH_IK_SOLVER (now it uses Eigen) or we use WITH_MOD_BOOLEAN (it was used by bsp intern library some time ago but it is not present in the code anymore).

Diff Detail

Repository
rB Blender

Event Timeline

Jorge Bernal (lordloki) updated this revision to Diff 8175.Jan 24 2017, 10:06 PM
Jorge Bernal (lordloki) retitled this revision from to CMake: Remove MOTO library dependency when it is not needed..
Jorge Bernal (lordloki) updated this object.
Jorge Bernal (lordloki) added reviewers: Sergey Sharybin (sergey), Bastien Montagne (mont29).
Jorge Bernal (lordloki) set the repository for this revision to rB Blender.
Sergey Sharybin (sergey) accepted this revision.Feb 6 2017, 10:47 AM
Sergey Sharybin (sergey) edited edge metadata.

The patch needs update to cleanly apply on current master, but the change seems good to me

This revision is now accepted and ready to land.Feb 6 2017, 10:47 AM
Closed by commit rBdbdc346e9ff6: CMake: Remove MOTO library dependency when it is not needed (authored by Jorge Bernal (lordloki)). · Explain WhyFeb 6 2017, 7:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
intern/
2 lines

Diff 8237

View Options

intern/CMakeLists.txt

Loading...