Page MenuHome
Differential D2480

blender 2.8: OpenGL immediate mode: editmesh_loopcut.c
ClosedPublic
Actions

Authored by Luca Rood (LucaRood) on Jan 27 2017, 6:04 AM.

Details

Reviewers
Mike Erwin (merwin)
Maniphest Tasks
T49043: replace OpenGL immediate mode in Blender 2.8
Commits
rBS85174329d9f5: blender 2.8: OpenGL immediate mode: editmesh_loopcut.c
rB85174329d9f5: blender 2.8: OpenGL immediate mode: editmesh_loopcut.c

Diff Detail

Repository
rB Blender

Event Timeline

Luca Rood (LucaRood) updated this revision to Diff 8190.Jan 27 2017, 6:04 AM
Luca Rood (LucaRood) retitled this revision from to blender 2.8: OpenGL immediate mode: editmesh_loopcut.c.
Luca Rood (LucaRood) updated this object.
Luca Rood (LucaRood) added a reviewer: Mike Erwin (merwin).
Luca Rood (LucaRood) set the repository for this revision to rB Blender.
Luca Rood (LucaRood) added a project: BF Blender: 2.8.
Luca Rood (LucaRood) added a task: T49043: replace OpenGL immediate mode in Blender 2.8.
Luca Rood (LucaRood) added a subscriber: Dalai Felinto (dfelinto).
Dalai Felinto (dfelinto) added a comment.Jan 28 2017, 11:03 AM
This comment was removed by Dalai Felinto (dfelinto).
Dalai Felinto (dfelinto) added a comment.Jan 28 2017, 11:07 AM
This comment was removed by Dalai Felinto (dfelinto).
Dalai Felinto (dfelinto) added inline comments.Jan 28 2017, 11:18 AM
source/blender/editors/mesh/editmesh_loopcut.c
118

not so sure about this one, don't we have a way to pass the entire vertex pointer in one go? @Mike Erwin (merwin)?

Mike Erwin (merwin) accepted this revision.Jan 28 2017, 2:51 PM
Mike Erwin (merwin) edited edge metadata.
Mike Erwin (merwin) added inline comments.
source/blender/editors/mesh/editmesh_loopcut.c
118

The batch API has that, but is overkill for this function. immBegin/End is good here :)

This revision is now accepted and ready to land.Jan 28 2017, 2:51 PM
Mike Erwin (merwin) closed this revision.Jan 31 2017, 9:14 AM

Landed in blender2.8

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
34 lines

Diff 8190

View Options

source/blender/editors/mesh/editmesh_loopcut.c

Loading...