Differential D2482

blender 2.8: OpenGL immediate mode: transform_generics.c
ClosedPublic
Actions

Authored by Luca Rood (LucaRood) on Jan 27 2017, 6:21 AM.

Details

Reviewers

Mike Erwin (merwin)

Maniphest Tasks

T49043: replace OpenGL immediate mode in Blender 2.8

Commits

rBSeca2f918a793: OpenGL immediate mode: transform_generics.c

Diff Detail

Repository: rB Blender

Event Timeline

Luca Rood (LucaRood) updated this revision to Diff 8192.Jan 27 2017, 6:21 AM

Luca Rood (LucaRood) retitled this revision from to blender 2.8: OpenGL immediate mode: transform_generics.c.

Luca Rood (LucaRood) updated this object.

Luca Rood (LucaRood) added a reviewer: Mike Erwin (merwin).

Luca Rood (LucaRood) set the repository for this revision to rB Blender.

Luca Rood (LucaRood) added a project: BF Blender: 2.8.

Luca Rood (LucaRood) added a task: T49043: replace OpenGL immediate mode in Blender 2.8.

Luca Rood (LucaRood) added a subscriber: Dalai Felinto (dfelinto).

LGTM. I find strange that the patch shows "no context" though. Did you use arc diff?

I always use git diff (not arc), but afaik only commits show context, not diffs (even arc diffs). Doesn't arc just call git diff anyway?

Arc will show context see D2446

@Luca Rood (LucaRood) You can land accepted revisions since you have commit access.

source/blender/editors/transform/transform_generics.c
1060	Almost certain this line isn't needed. If you agree, remove it and the BIF_glutil.h include.

This revision is now accepted and ready to land.Jan 31 2017, 9:55 AM

@Luca Rood (LucaRood) just remember to "arc land --onto blender2.8"

Pushed to blender2.8

source/blender/editors/transform/transform_generics.c
1060	Indeed.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

transform/

transform_generics.c

24 lines

Diff 8192

View Options

source/blender/editors/transform/transform_generics.c

blender 2.8: OpenGL immediate mode: transform_generics.cClosedPublicActions