Page MenuHome
Differential D2485

blender 2.8: OpenGL immediate mode: view3d_ruler.c
AbandonedPublic
Actions

Authored by Luca Rood (LucaRood) on Jan 27 2017, 6:39 AM.

Details

Reviewers
Mike Erwin (merwin)
Maniphest Tasks
T49043: replace OpenGL immediate mode in Blender 2.8
Commits
rBS2e8be8ac6b33: OpenGL immediate mode: view3d_ruler.c
Summary

Note that three calls to glColor3ubv remain, two of which are for the text, and as far as I can tell can not be removed until we have a BLF_color function.

The third glColor3ubv is for circ, and was actually previously a cpack, but I replaced it as I changed the format of the color variable. But to be honest, I didn't really look into this third glColor3ubv and the circ function, as it ended up getting kinda late, so maybe this one can already be replaced...

Diff Detail

Repository
rB Blender

Event Timeline

Luca Rood (LucaRood) updated this revision to Diff 8195.Jan 27 2017, 6:39 AM
Luca Rood (LucaRood) retitled this revision from to blender 2.8: OpenGL immediate mode: view3d_ruler.c.
Luca Rood (LucaRood) updated this object.
Luca Rood (LucaRood) added a reviewer: Mike Erwin (merwin).
Luca Rood (LucaRood) set the repository for this revision to rB Blender.
Luca Rood (LucaRood) added a project: BF Blender: 2.8.
Luca Rood (LucaRood) added a task: T49043: replace OpenGL immediate mode in Blender 2.8.
Luca Rood (LucaRood) added a subscriber: Dalai Felinto (dfelinto).
Luca Rood (LucaRood) planned changes to this revision.Jan 28 2017, 3:17 PM

Will replace the immAttrib3ub calls with immUniformColor.

Mike Erwin (merwin) edited edge metadata.Jan 31 2017, 10:13 AM

You're right about glColor being used by BLF. I've got BLF_color implemented, will commit soon!

source/blender/editors/space_view3d/view3d_ruler.c
44

Still need this?

Mike Erwin (merwin) added inline comments.Jan 31 2017, 10:17 AM
source/blender/editors/space_view3d/view3d_ruler.c
708–709

Not sure exactly what circ is doing, but FYI we have imm_draw_lined_circle & imm_draw_filled_circle available.

Luca Rood (LucaRood) abandoned this revision.Feb 2 2017, 1:27 AM

Pushed to blender2.8

source/blender/editors/space_view3d/view3d_ruler.c
44

Yes, as long as the old matrix stuff is used.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_view3d/
218 lines

Diff 8195

View Options

source/blender/editors/space_view3d/view3d_ruler.c

Loading...