Paths

Table of Contentst

Differential D2497

blender2.8: New immediate mode for sculpt_uv.c
AbandonedPublic
Actions

Authored by Tobias Mertz (TCMBoby) on Feb 2 2017, 10:23 PM.

Tags

Subscribers

Dalai Felinto (dfelinto)

Details

Reviewers

Mike Erwin (merwin)

Maniphest Tasks

T49043: replace OpenGL immediate mode in Blender 2.8

Commits

rBS077988dd44f7: blender2.8: New immediate mode for sculpt_uv.c
rB077988dd44f7: blender2.8: New immediate mode for sculpt_uv.c

Summary

Replaced the one call to glutil_draw_lined_arc.
This seems to be the only draw call in this file.

Diff Detail

Repository

Branch

arcpatch-D2497

Build Status

Buildable 427
Build 427: arc lint + arc unit

Event Timeline

Tobias Mertz (TCMBoby) updated this revision to Diff 8227.Feb 2 2017, 10:23 PM

Tobias Mertz (TCMBoby) retitled this revision from to blender2.8: New immediate mode for sculpt_uv.c.

Tobias Mertz (TCMBoby) updated this object.

Tobias Mertz (TCMBoby) updated this object.Feb 2 2017, 10:27 PM

Tobias Mertz (TCMBoby) added a reviewer: Mike Erwin (merwin).

Tobias Mertz (TCMBoby) added a project: BF Blender: 2.8.

Tobias Mertz (TCMBoby) added a task: T49043: replace OpenGL immediate mode in Blender 2.8.

Mike Erwin (merwin) added inline comments.Feb 8 2017, 8:50 PM

source/blender/editors/sculpt_paint/sculpt_uv.c
66–67	Still need this after converting?
220	Could use immUniformColor3fvAlpha(brush->add_col, alpha)
224–231	We have a utility function for this: imm_draw_lined_circle(pos, x, y, size, 40); That would let you get rid of the "int i", glPushMatrix, glTranslatef, and glPopMatrix. Nice!

Replaced loop and removed unnecessary include in sculpt_uv.c

Mike Erwin (merwin) mentioned this in rBbf83f097ad7e: Immediate Mode: sculpt_uv.c.Feb 16 2017, 8:46 PM

Committed on rB077988dd. Thanks for the contribution keep them coming :)

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

22 lines

Diff 8255

source/blender/editors/sculpt_paint/sculpt_uv.c

Loading...