Diff to solve Task T47222 in Quick Hacks based on previous work with added modifications.
Created an option for UV unwrapping from cursor position.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
The code works... in part. (There are some problems):
| source/blender/editors/uvedit/uvedit_unwrap_ops.c | ||
|---|---|---|
| 1500 | *center = *ED_view3d_cursor3d_get(scene, v3d);``` is wrong :\ `center` here is only copying the first element of the array (center[0]). Try using `copy_v3_v3(center, ED_view3d_cursor3d_get(scene, v3d))` instead. There is also no need to calculate the previous value of the `center` since it is overwritten by the cursor3d. This is inefficient. You must separate the function that calculates the `center` and only use with `else`. | |
| 1586 | same as the previous comment | |
| 1680 | This function is very similar to ED_uvedit_unwrap_cube_project. Try to avoid duplicates. This increases the code and makes it difficult to maintain. It is also difficult to say what is this float *off Suggestion: You can add this parameter to ED_uvedit_unwrap_cube_project And put as NULL if it does not have offset. ED_uvedit_unwrap_cube_project(ob, bm, cube_size, NULL); | |
Comment Actions
Here's a guide to blender CodeStyle ;)
https://wiki.blender.org/index.php/Dev:Doc/Code_Style
| source/blender/editors/include/ED_uvedit.h | ||
|---|---|---|
| 104 | use const float offset[3]... becomes more descriptive | |
| source/blender/editors/uvedit/uvedit_unwrap_ops.c | ||
| 976 | In this case this function can be independent. The center can be obtained outside | |
| 1491 | Why not call cursor_center just like the name of the property? | |
| 1502 | Be careful about the value of center being local | |
| 1639 | const float offset[3] | |
| 1678 | The loc value can be changed before the loop. float loc[3];
if (offset) {
add_v3_v3v3(loc, ob->obmat[3], offset);
}
else {
copy_v3_v3(loc, ob->obmat[3]);
} | |
| 1705 | ~cursor_unwrap~ > cursor_center | |
| 1708 | The value of cursor_loc must be local | |
Comment Actions
Hi, I didn't catch a few remarks.
About the value of 'center' being local, it shouldn't be local to the IF statement as it has been declared earlier?
Also, I believe the value of cursor_loc may actually be local as suggested.
Am I missing something?
Comment Actions
Went to apply this patch but found the use of center values was buggy and not always in the correct space.
Committed related changes rB759b50b20b96556f182e6d14ce23a89e2a673921
Currently there are a handful of tools that use v3d->around - We could make this into an operator option, so the user can optionally override the 3d view.