Page MenuHome
Differential D2554

Fix T50888: Numeric overflow in split kernel state buffer size calculation
ClosedPublic
Actions

Authored by Mai Lavelle (maiself) on Mar 11 2017, 11:43 AM.

Details

Reviewers
Hristo Gueorguiev (nirved)
Sergey Sharybin (sergey)
Maniphest Tasks
T50888: Master Broken, Cuda kernel compat errors compile, OpenCL GPU just sits there on one tile never rendering anything.
Summary

Overflow led to the state buffer being too small and the split kernel to get stuck doing nothing forever.

Diff Detail

Event Timeline

Mai Lavelle (maiself) updated this revision to Diff 8408.Mar 11 2017, 11:43 AM
Mai Lavelle (maiself) retitled this revision from to Fix T50888: Numeric overflow in split kernel state buffer size calculation.
Mai Lavelle (maiself) updated this object.
Mai Lavelle (maiself) added reviewers: Sergey Sharybin (sergey), Hristo Gueorguiev (nirved).
Mai Lavelle (maiself) added a task: T50888: Master Broken, Cuda kernel compat errors compile, OpenCL GPU just sits there on one tile never rendering anything..
Sergey Sharybin (sergey) edited edge metadata.Mar 11 2017, 11:49 AM

This is a bit confusing to mix size_t and int64_t. Is that to ensure 64 bit address space on 32bit platforms?

Mai Lavelle (maiself) added a comment.Mar 11 2017, 11:52 AM
In D2554#59775, @Sergey Sharybin (sergey) wrote:

This is a bit confusing to mix size_t and int64_t. Is that to ensure 64 bit address space on 32bit platforms?

Yes and also to deal with passing data to and from OpenCL kernels, as you cant pass size_t there.

Sergey Sharybin (sergey) accepted this revision.Mar 11 2017, 12:10 PM
Sergey Sharybin (sergey) edited edge metadata.

Ok, i see. Don't have much to comment about then. If it compiles/works just go ahead then.

This revision is now accepted and ready to land.Mar 11 2017, 12:10 PM
Mai Lavelle (maiself) closed this revision.Mar 11 2017, 12:26 PM
James W E Bird (3dLuver) awarded a token.Mar 11 2017, 1:38 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
device/
4 lines
8 lines
9 lines
4 lines
4 lines
opencl/
6 lines
10 lines
kernel/
kernels/
cuda/
2 lines
opencl/
2 lines
split/
4 lines
util/
16 lines

Diff 8408

View Options

intern/cycles/device/device_cpu.cpp

Loading...
View Options

intern/cycles/device/device_cuda.cpp

Loading...
View Options

intern/cycles/device/device_memory.h

Loading...
View Options

intern/cycles/device/device_split_kernel.h

Loading...
View Options

intern/cycles/device/device_split_kernel.cpp

Loading...
View Options

intern/cycles/device/opencl/opencl_base.cpp

Loading...
View Options

intern/cycles/device/opencl/opencl_split.cpp

Loading...
View Options

intern/cycles/kernel/kernels/cuda/kernel_split.cu

Loading...
View Options

intern/cycles/kernel/kernels/opencl/kernel_state_buffer_size.cl

Loading...
View Options

intern/cycles/kernel/split/kernel_split_data.h

Loading...
View Options

intern/cycles/util/util_types.h

Loading...