Paths

Table of Contentst

Differential D2590

Cycles Denoising: Part 1: Preparation changes
ClosedPublic
Actions

Authored by Lukas Stockner (lukasstockner97) on Mar 31 2017, 2:18 AM.

Tags

None

Subscribers

Hristo Gueorguiev (nirved)

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)
Thomas Dinges (dingto)
Mai Lavelle (maiself)
Martijn Berger (juicyfruit)
Stefan Werner (swerner)

Summary

These changes don't affect behaviour at all, but are needed later.

They include:

New approach of handling CPU kernel entry points (needed since the filter has a lot of kernels)
Dedicated control over tile highlighting (needed to re-highlight tiles when they're being denoised)
Renaming the PATH_TRACE task (it will handle both path tracing and denoising later)
Device-only memory: Already used in the split kernel, now a separate class
Several changes in the kernel to improve numerical stability and prevent NaNs

Diff Detail

Repository

Build Status

Buildable 506
Build 506: arc lint + arc unit

Event Timeline

Lukas Stockner (lukasstockner97) created this revision.Mar 31 2017, 2:18 AM

Lukas Stockner (lukasstockner97) added a child revision: D2591: Cycles Denoising: Part 2: Generating the feature passes in the kernel.Mar 31 2017, 2:23 AM

Lukas Stockner (lukasstockner97) added a child revision: D2592: Cycles Denoising: Part 3: Denoiser Kernels.

Lukas Stockner (lukasstockner97) added a child revision: D2593: Cycles Denoising: Part 4: Host side of the denoiser code.Mar 31 2017, 2:26 AM

Only did a quick look right now, will look over the rest later. I like the changes to how kernels are handled.

intern/cycles/device/device_cpu.cpp
121	What will happen if the architecture is changed in the debug panel?
397	split_kernel is leaked here.
intern/cycles/kernel/kernels/cpu/kernel_cpu_impl.h
200	No KERNEL_STUB for this?

Harbormaster completed remote builds in B506: Diff 8520.Mar 31 2017, 8:53 AM

Hristo Gueorguiev (nirved) added a subscriber: Hristo Gueorguiev (nirved).Apr 1 2017, 12:48 PM

Hristo Gueorguiev (nirved) added inline comments.

intern/cycles/kernel/kernel_path.h
682	This didn't make it to split kernel.

Thanks for the initial review, should all be fixed now.

Harbormaster completed remote builds in B518: Diff 8553.Apr 6 2017, 3:34 AM

What is the reason for moving N from the specific BSDFs to all of them? Hair and transparent do not have a valid normal, and since they are not really meaningful in those cases it seems better not to have them at all, so that they can't be used accidentally.

Edit: seems this is needed for D2591.

intern/cycles/device/device_cpu.cpp
57	This is not strictly thread safe, we support running multiple render sessions at the same time. With a `const char*` instead of a `string` it should be safe enough though.
intern/cycles/kernel/kernel_path.h
326	I'm not sure what this does, I can't tell what kind of difference this makes even assuming there are NaNs.

Addressed review.

Harbormaster completed remote builds in B586: Diff 8684.Apr 22 2017, 12:37 AM

This revision is now accepted and ready to land.Apr 22 2017, 1:47 AM

Just a rebase, no real changes.

Lukas Stockner (lukasstockner97) closed this revision.May 25 2017, 4:51 AM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

blender/

blender_session.h

4 lines

blender_session.cpp

23 lines

device/

578 lines

device_cuda.cpp

72 lines

device_memory.h

21 lines

device_split_kernel.h

6 lines

device_split_kernel.cpp

6 lines

4 lines

device_task.cpp

6 lines

opencl/

4 lines

opencl_base.cpp

53 lines

opencl_mega.cpp

2 lines

opencl_split.cpp

2 lines

kernel/

27 lines

closure/

bsdf_ashikhmin_velvet.h

1 line

1 line

bsdf_diffuse_ramp.h

1 line

bsdf_microfacet.h

1 line

bsdf_microfacet_multi.h

2 lines

bsdf_oren_nayar.h

1 line

bsdf_phong_ramp.h

1 line

1 line

1 line

geom/

geom_triangle.h

6 lines

38 lines

2 lines

2 lines

kernel_projection.h

3 lines

kernel_shader.h

6 lines

5 lines

kernels/

cpu/

30 lines

kernel_avx2.cpp

32 lines

2 lines

kernel_cpu_impl.h

76 lines

kernel_split_avx.cpp

29 lines

kernel_split_avx2.cpp

32 lines

kernel_split_sse2.cpp

20 lines

kernel_split_sse3.cpp

24 lines

kernel_split_sse41.cpp

26 lines

kernel_sse2.cpp

20 lines

kernel_sse3.cpp

24 lines

kernel_sse41.cpp

26 lines

svm/

2 lines

9 lines

1 line

4 lines

8 lines

render/

2 lines

4 lines

16 lines

util/

42 lines

source/

blender/

makesrna/

intern/

1 line

render/

extern/

include/

2 lines

intern/

source/

external_engine.c

4 lines

blenderplayer/

bad_level_call_stubs/

2 lines

Diff 8520

intern/cycles/blender/blender_session.h

Loading...

intern/cycles/blender/blender_session.cpp

Loading...

intern/cycles/device/device_cpu.cpp

Loading...

intern/cycles/device/device_cuda.cpp

Loading...

intern/cycles/device/device_memory.h

Loading...

intern/cycles/device/device_split_kernel.h

Loading...

intern/cycles/device/device_split_kernel.cpp

Loading...

intern/cycles/device/device_task.h

Loading...

intern/cycles/device/device_task.cpp

Loading...

intern/cycles/device/opencl/opencl.h

Loading...

intern/cycles/device/opencl/opencl_base.cpp

Loading...

intern/cycles/device/opencl/opencl_mega.cpp

Loading...

intern/cycles/device/opencl/opencl_split.cpp

Loading...

intern/cycles/kernel/CMakeLists.txt

Loading...

intern/cycles/kernel/closure/bsdf_ashikhmin_velvet.h

Loading...

intern/cycles/kernel/closure/bsdf_diffuse.h

Loading...

intern/cycles/kernel/closure/bsdf_diffuse_ramp.h

Loading...

intern/cycles/kernel/closure/bsdf_microfacet.h

Loading...

intern/cycles/kernel/closure/bsdf_microfacet_multi.h

Loading...

intern/cycles/kernel/closure/bsdf_oren_nayar.h

Loading...

intern/cycles/kernel/closure/bsdf_phong_ramp.h

Loading...

intern/cycles/kernel/closure/bsdf_toon.h

Loading...

intern/cycles/kernel/closure/bssrdf.h

Loading...

intern/cycles/kernel/geom/geom_triangle.h

Loading...

intern/cycles/kernel/kernel.h

Loading...

intern/cycles/kernel/kernel_light.h

Loading...

intern/cycles/kernel/kernel_path.h

Loading...

intern/cycles/kernel/kernel_projection.h

Loading...

intern/cycles/kernel/kernel_shader.h

Loading...

intern/cycles/kernel/kernel_types.h

Loading...

intern/cycles/kernel/kernels/cpu/kernel_avx.cpp

Loading...

intern/cycles/kernel/kernels/cpu/kernel_avx2.cpp

Loading...

intern/cycles/kernel/kernels/cpu/kernel_cpu.h

Loading...

intern/cycles/kernel/kernels/cpu/kernel_cpu_impl.h

Loading...

intern/cycles/kernel/kernels/cpu/kernel_split_avx.cpp

Loading...

intern/cycles/kernel/kernels/cpu/kernel_split_avx2.cpp

Loading...

intern/cycles/kernel/kernels/cpu/kernel_split_sse2.cpp

Loading...

intern/cycles/kernel/kernels/cpu/kernel_split_sse3.cpp

Loading...

intern/cycles/kernel/kernels/cpu/kernel_split_sse41.cpp

Loading...

intern/cycles/kernel/kernels/cpu/kernel_sse2.cpp

Loading...

intern/cycles/kernel/kernels/cpu/kernel_sse3.cpp

Loading...

intern/cycles/kernel/kernels/cpu/kernel_sse41.cpp

Loading...

intern/cycles/kernel/svm/svm_closure.h

Loading...

intern/cycles/kernel/svm/svm_displace.h

Loading...

intern/cycles/kernel/svm/svm_geometry.h

Loading...

intern/cycles/kernel/svm/svm_image.h

Loading...

intern/cycles/kernel/svm/svm_types.h

Loading...

intern/cycles/render/mesh.cpp

Loading...

intern/cycles/render/session.h

Loading...

intern/cycles/render/session.cpp

Loading...

intern/cycles/util/util_math.h

Loading...

source/blender/makesrna/intern/rna_render.c

Loading...

source/blender/render/extern/include/RE_engine.h

Loading...

source/blender/render/intern/source/external_engine.c

Loading...

source/blenderplayer/bad_level_call_stubs/stubs.c

Loading...