Page MenuHome
Differential D2626

GPU Matrix API: stick to a single 4x4 matrix stick for 2D and 3D
ClosedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Apr 14 2017, 2:47 PM.

Details

Reviewers
Mike Erwin (merwin)
Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)
Maniphest Tasks
T49450: replace OpenGL legacy matrix stacks
Commits
rBScb2c4bfb74ca: GPU Matrix API refactor: Stick to a single 4x4 stack for 2D and 3D
rBcb2c4bfb74ca: GPU Matrix API refactor: Stick to a single 4x4 stack for 2D and 3D
Summary

This patch is made of three patches:

  • Use only 3d matrices
  • Removing Matrix 2D storage entirely
  • Removing gpuBegin/End functions

You can read a related discussion on:
https://lists.blender.org/pipermail/bf-committers/2017-April/048301.html

And if you build with core profile and this patch you get:

(the text glitch is an unrelated issue).

Diff Detail

Repository
rB Blender
Branch
temp-gpu-matrix-3d
Build Status
Buildable 566
Build 566: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) created this revision.Apr 14 2017, 2:47 PM
Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)Apr 14 2017, 2:49 PM
Dalai Felinto (dfelinto) added a project: BF Blender: 2.8.
Dalai Felinto (dfelinto) added a subscriber: Luca Rood (LucaRood).
Brecht Van Lommel (brecht) accepted this revision.Apr 14 2017, 3:19 PM

Agreed, the fewer modes and states we need to keep track of the better.

This revision is now accepted and ready to land.Apr 14 2017, 3:19 PM
Dalai Felinto (dfelinto) updated this revision to Diff 8639.Apr 14 2017, 3:44 PM
  • Fixup on "Use only 3d matrices"
Dalai Felinto (dfelinto) updated this revision to Diff 8640.Apr 14 2017, 3:46 PM
  • Fixup again
Mike Erwin (merwin) edited edge metadata.Apr 14 2017, 5:32 PM

This patch rejects a fundamental change I've been trying to make -- that 2D is different from 3D and deserves its own best implementation.

What I like about this patch:

  • it makes our matrix API closer to old familiar OpenGL
  • user code doesn't need to setup/teardown <-- best part
  • code is shorter

That's about it!

If my fellow devs prefer this unified matrix stack (focused on 3D) then let's use it. I can express these ideas about 2D graphics outside of Blender.

Mike Erwin (merwin) accepted this revision.Apr 14 2017, 5:38 PM

Tested on Mac, land it!

Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).Apr 14 2017, 6:01 PM

I do not know much about this API but ... using matrix3D like 2D does not seem very efficient :\

On the other hand, simplifying the code is always desirable

Dalai Felinto (dfelinto) closed this revision.Apr 14 2017, 6:12 PM

Landed on rBcb2c4bfb74ca7f385bbd8d7c3445a49a2d1b7b8d . Thanks everyone for the feedback and the positive attitude, really.

Mike Erwin (merwin) mentioned this in rB4b043994e879: GPU Matrix API: clean up after 2D-3D unification.Apr 15 2017, 7:31 AM
Mike Erwin (merwin) added a task: T49450: replace OpenGL legacy matrix stacks.Apr 15 2017, 7:45 AM
Mike Erwin (merwin) mentioned this in rB2593ce9c3327: Gawain: remove 2D matrix uniforms from ShaderInterface.Apr 16 2017, 12:07 AM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
intern/
4 lines
4 lines
editors/
space_view3d/
4 lines
gpu/
16 lines
intern/
5 lines
347 lines

Diff 8640

View Options

source/blender/draw/intern/draw_manager.c

Loading...
View Options

source/blender/draw/intern/draw_view.c

Loading...
View Options

source/blender/editors/space_view3d/view3d_draw.c

Loading...
View Options

source/blender/gpu/GPU_matrix.h

Loading...
View Options

source/blender/gpu/intern/gpu_framebuffer.c

Loading...
View Options

source/blender/gpu/intern/gpu_matrix.c

Loading...