This upgrade the drawing code to use latest opengl calls.
Also, it adds a fallback shader for opencolorio.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- temp-cycles-viewport-device
- Build Status
Buildable 614 Build 614: arc lint + arc unit
Event Timeline
Comment Actions
Some quick feedback. Code style mainly. Logic is seems fine.
Especially after hunting that texture issue.
| intern/cycles/device/device.cpp | ||
|---|---|---|
| 107–155 | Put TODO() statement about movingthis to a standalone .glsl file. Currently we don't have datatoc app in standalone repo, so doing that might be tricky now. But in the future would be nice to move that out. | |
| 168 | No space after keyword in Cycles. | |
| 171 | Use #include "util/util_string.h" and use string. Direct std:: is quite banned in Cycles code. | |
| 180 | Space. And cases below i guess. | |
| 181 | LOG(ERROR) << "Failed to compile"; Make sure #include "util/util_logging.h" is included. ERROR should be always printed. If it foes not, kick me (if there is a mistake in code, the ERROR might only be visible with --debug-cycles). | |
| 184 | Type *pointer No need in new i guess. While string is unusable here, doing vector message(log_size) would make a trick. As a positive side -- no need to delete. | |
| 200 | Can we move that to an utility function in an anonymous namespace/static function instead. | |
| intern/cycles/device/device.h | ||
| 235 | Make SUCCESS instead of GOOD? | |
Comment Actions
- From review: GOOD > SUCCESS
- From review: use util functions, code style
Note: LOG(ERROR) is only printed when --debug-cycles
Note 2: Shader is no longer working when not using opencolorio