Details

Reviewers

Commits

rBS20f95de6ba2d: Weight painting with draw manager
rB20f95de6ba2d: Weight painting with draw manager

Summary

This implements basic weight rendering with the draw manager.
Drawing options are still missing (vertex and face selection masking).

Also, there are two known crashes:

If two objects have the same mesh, there is a segfault when entering weight painting mode unless the object is the last on being drawn with that mesh (this seems to be related to where caches are being stored, and it seems that maybe there are going to be some changes in that area, so we'll see how this goes).
If you close Blender while in weight painting mode, it segfaults (most useless segfault ever, hehe).

This is part of T51208

Diff Detail

Repository

rB Blender

Branch

weight-patch (branched from blender2.8)

Build Status

Buildable 623
Build 623: arc lint + arc unit

Event Timeline

Luca Rood (LucaRood) created this revision.May 1 2017, 3:33 PM

Harbormaster completed remote builds in B617: Diff 8746.May 1 2017, 3:33 PM

Some nitpicking comments, feel free to ignore most of them (the comment about 120 fallback is serious though).

source/blender/draw/modes/paint_weight_mode.c
106–107	-if (!e_data.weight_face_shader) { +if (e_data.weight_face_shader == NULL) {
129	maybe leave the "/* Uniforms need a pointer to it's value so be sure it's accessible" comment?
source/blender/gpu/shaders/gpu_shader_simple_lighting_smooth_color_alpha_frag.glsl
7	no need for 120 fallback
source/blender/makesdna/DNA_ID.h
106	- IDP_GROUP_SUB_MODE_PAINT_WEIGHT = 5 + IDP_GROUP_SUB_MODE_PAINT_WEIGHT = 5,

Added all drawing options (Wire, shading, face mask and vert mask), did some minor style fixes, and added support for the custom weight color setting (debatable usefulness).

Fixed all crashes and memleaks. Weight cache invalidation is a bit hacky, but is the simplest way to do it for now, and can be changed later.

Harbormaster completed remote builds in B621: Diff 8755.May 3 2017, 4:19 PM

Fixed one last corner case where the draw cache wasn't updated (different object with same mesh).

Added ensure BM dvert, and rebased.

Closed by commit rB20f95de6ba2d: Weight painting with draw manager (authored by Luca Rood (LucaRood)). · Explain WhyMay 3 2017, 7:00 PM

This revision was automatically updated to reflect the committed changes.

Weight painting with draw manager
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 8759

release/scripts/startup/bl_ui/properties_collection.py

source/blender/blenkernel/BKE_mesh.h

source/blender/blenkernel/intern/deform.c

source/blender/blenkernel/intern/layer.c

source/blender/blenkernel/intern/object_deform.c

source/blender/draw/DRW_engine.h

source/blender/draw/intern/draw_cache.h

source/blender/draw/intern/draw_cache.c

source/blender/draw/intern/draw_cache_impl.h

source/blender/draw/intern/draw_cache_impl_mesh.c

source/blender/draw/modes/object_mode.c

source/blender/draw/modes/paint_weight_mode.c

source/blender/editors/mesh/editface.c

source/blender/editors/sculpt_paint/paint_stroke.c

source/blender/editors/sculpt_paint/paint_vertex.c

source/blender/gpu/CMakeLists.txt

source/blender/gpu/GPU_shader.h

source/blender/gpu/intern/gpu_shader.c

source/blender/gpu/shaders/gpu_shader_simple_lighting_smooth_color_alpha_frag.glsl

source/blender/makesdna/DNA_ID.h

source/blender/makesdna/DNA_layer_types.h

source/blender/makesrna/intern/rna_mesh.c

source/blender/makesrna/intern/rna_scene.c

Weight painting with draw managerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8759

release/scripts/startup/bl_ui/properties_collection.py

source/blender/blenkernel/BKE_mesh.h

source/blender/blenkernel/intern/deform.c

source/blender/blenkernel/intern/layer.c

source/blender/blenkernel/intern/object_deform.c

source/blender/draw/DRW_engine.h

source/blender/draw/intern/draw_cache.h

source/blender/draw/intern/draw_cache.c

source/blender/draw/intern/draw_cache_impl.h

source/blender/draw/intern/draw_cache_impl_mesh.c

source/blender/draw/modes/object_mode.c

source/blender/draw/modes/paint_weight_mode.c

source/blender/editors/mesh/editface.c

source/blender/editors/sculpt_paint/paint_stroke.c

source/blender/editors/sculpt_paint/paint_vertex.c

source/blender/gpu/CMakeLists.txt

source/blender/gpu/GPU_shader.h

source/blender/gpu/intern/gpu_shader.c

source/blender/gpu/shaders/gpu_shader_simple_lighting_smooth_color_alpha_frag.glsl

source/blender/makesdna/DNA_ID.h

source/blender/makesdna/DNA_layer_types.h

source/blender/makesrna/intern/rna_mesh.c

source/blender/makesrna/intern/rna_scene.c

Weight painting with draw manager
ClosedPublic
Actions

Revision Contents
Changeset List