Fix C++11 build error
AbandonedPublic
Actions

Authored by Tanel Tagaväli (theblu) on May 18 2017, 12:57 AM.

Details

Reviewers

Summary

Math functions in C++11 require an explicit cast before calling them, an ambiguous function overload error is thrown otherwise.

Relevant docs:
https://msdn.microsoft.com/en-us/library/da60x087.aspx#code-snippet-4
http://en.cppreference.com/w/cpp/numeric/math/isfinite

Diff Detail

Repository: rB Blender

Event Timeline

Tanel Tagaväli (theblu) created this revision.May 18 2017, 12:57 AM

Tanel Tagaväli (theblu) edited the summary of this revision. (Show Details)May 18 2017, 12:59 AM

Tanel Tagaväli (theblu) edited the summary of this revision. (Show Details)May 18 2017, 1:03 AM

This is incorrect to cast here. This is a part of templated function which is run for float, uchar and half and for latter two ones you want this to be a no-op check.

Please make sure you're testing sources with rB9a910443c47 included. If the bug still happens please provide configuration flag you was using.

This revision now requires changes to proceed.May 18 2017, 9:38 AM

Yup, rB9a910443c47 fixed it.

Revision Contents
Changeset List

Path

Size

intern/

cycles/

render/

image.cpp

10 lines

Diff 8809

View Options

intern/cycles/render/image.cpp

Fix C++11 build errorAbandonedPublicActions