Details

Reviewers

Bastien Montagne (mont29)
Sergey Sharybin (sergey)
Dalai Felinto (dfelinto)

Maniphest Tasks

T51382: Proposal for removing TexFace in 2.8x

Summary

For full proposal see: T51382

Summary

The workflow for UV-editing now uses the active face materials 'edit-image' instead of active 'texface'.

This uses BKE_object_material_edit_image_get/set for most of the API, so we can more easily change internal storage later if we want.
Baking also uses edit-image instead of texface.
Game engine uses edit-image too, this isn't correct, its more a place-holder alternative to showing nothing.
Game engine image text no longer works *(could be supported but would need some changes to API to pass around an image/material)*.

Diff Detail

Repository

rB Blender

Branch

TEMP-TEXFACE

Build Status

Buildable 658
Build 658: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) created this revision.May 23 2017, 1:15 PM

Campbell Barton (campbellbarton) added a task: T51382: Proposal for removing TexFace in 2.8x.May 23 2017, 1:16 PM

Campbell Barton (campbellbarton) retitled this revision from Remove texface, use material edit-image instead. to 2.8x: Remove texface, use material edit-image instead.May 23 2017, 1:21 PM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)

Campbell Barton (campbellbarton) added a reviewer: Dalai Felinto (dfelinto).

Correct error

Add missing extern call

Remove unused vars

Only did quick check, but lgtm. Nice to see so much ugly code in the “red area”! :D

source/blender/makesdna/DNA_material_types.h
215	typo, feature ;)

This revision is now accepted and ready to land.May 23 2017, 1:54 PM

Ulysse Martin (youle) added subscribers: Ulysse Martin (youle), Porteries Tristan (panzergame).May 23 2017, 1:56 PM

Remove object from multi-res baker (use material aligned array instead)

Quiet warnings

Remove TexFace from collada

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)May 23 2017, 2:58 PM

Porteries Tristan (panzergame) added inline comments.May 23 2017, 4:09 PM

source/blender/gpu/intern/gpu_draw.c
110	This feature is very boring in UPBGE and in blender with mtexpoly here. For the moment it was removed in the UPBGE sources but i don't know if it's acceptable for you @Campbell Barton (campbellbarton).

Campbell Barton (campbellbarton) added inline comments.May 24 2017, 2:21 AM

source/blender/gpu/intern/gpu_draw.c
110	The intent of this patch is to keep 2.8 working as-is. besides removing TexFace. Thats why I made this note. It seems like we will probably remove this feature later anyway (which is why I didn't make some API change to keep it supported).

Committed to 2.8 branch:

Remove image member rB7a9ad029dd1d1afe42d54c9c181de887636db7c0
Remove all non UV members from the struct. rBf2cc6c9254be5fe093e112f3b6e2192b392a1843
Entirely remove MTexPoly structure and layer type, drawing and update UI & version patch files. rBbdbf4471a6c4ba2d444eea5e7f0e6984b3aaafc2 rBc6e92b4947945e3c1238d936f7954a5b4688c195

2.8x: Remove texface, use material edit-image insteadClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8831

release/scripts/startup/bl_ui/properties_data_modifier.py

release/scripts/startup/bl_ui/properties_material.py

source/blender/blenkernel/BKE_material.h

source/blender/blenkernel/intern/customdata.c

source/blender/blenkernel/intern/library_query.c

source/blender/blenkernel/intern/material.c

source/blender/blenloader/intern/readfile.c

source/blender/blenloader/intern/versioning_legacy.c

source/blender/bmesh/intern/bmesh_operators.h

source/blender/bmesh/operators/bmo_similar.c

source/blender/editors/include/ED_uvedit.h

source/blender/editors/mesh/editmesh_select.c

source/blender/editors/object/object_bake.c

source/blender/editors/space_image/space_image.c

source/blender/editors/transform/transform_conversions.c

source/blender/editors/uvedit/uvedit_buttons.c

source/blender/editors/uvedit/uvedit_draw.c

source/blender/editors/uvedit/uvedit_ops.c

source/blender/editors/uvedit/uvedit_unwrap_ops.c

source/blender/gpu/intern/gpu_draw.c

source/blender/makesdna/DNA_material_types.h

source/blender/makesdna/DNA_meshdata_types.h

source/blender/makesdna/DNA_modifier_types.h

source/blender/makesrna/intern/rna_material.c

source/blender/makesrna/intern/rna_mesh.c

source/blender/makesrna/intern/rna_modifier.c

source/blender/modifiers/intern/MOD_uvproject.c

source/blender/python/bmesh/bmesh_py_types_meshdata.c

source/blender/render/extern/include/RE_multires_bake.h

source/blender/render/intern/source/bake.c

source/blender/render/intern/source/multires_bake.c

source/blender/render/intern/source/shadeinput.c

source/gameengine/Converter/BL_BlenderDataConversion.cpp

source/gameengine/Ketsji/KX_BlenderMaterial.cpp

source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_OpenGLRasterizer.cpp

2.8x: Remove texface, use material edit-image instead
ClosedPublic
Actions

Revision Contents
Changeset List