Fix for T51289
ClosedPublic
Actions

Authored by Danrae Pray (spockTheGray) on Jun 4 2017, 7:48 PM.

Details

Reviewers

Maniphest Tasks

T51289: Particle System UI issue/annoyance: setting Start later than End should increase End if necessary, rather than capping it

Commits

rB1e91d9d4dc49: Fix T51289: Particle System UI issue/annoyance: setting Start later than End…

Summary

Fixed T51289 in setter for start value. Wasn't sure who to put as reviewers, so I just added Aaron...

Diff Detail

Repository: rB Blender

Event Timeline

Danrae Pray (spockTheGray) created this revision.Jun 4 2017, 7:48 PM

Aaron Carlisle (Blendify) resigned from this revision.Jun 4 2017, 8:19 PM

Aaron Carlisle (Blendify) edited reviewers, added: Luca Rood (LucaRood); removed: Aaron Carlisle (Blendify).

Just saw this revision now, didn't catch the notification for this :|
This looks fine. Just note that the same should be done for the opposite case... Setting the end frame lower than the start frame should also lower it.

Ray Molenkamp (LazyDodo) mentioned this in D2724: [Modifiers] Screw modifier generates doubles. .Jul 26 2017, 4:31 PM

Updated the diff so it also adjusts the particle system start value if the end is changed to a value lower than start...

Tanner (devtanc) added a subscriber: Tanner (devtanc).Feb 8 2019, 7:08 AM

Tanner (devtanc) removed a subscriber: Tanner (devtanc).

This revision was not accepted when it landed; it landed in state Needs Review.Jan 17 2020, 2:25 PM

Closed by commit rB1e91d9d4dc49: Fix T51289: Particle System UI issue/annoyance: setting Start later than End… (authored by Danrae Pray (spockTheGray), committed by Sebastian Parborg (zeddb)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Sebastian Parborg (zeddb) added a commit: rB1e91d9d4dc49: Fix T51289: Particle System UI issue/annoyance: setting Start later than End….

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_particle.c

2 lines

Diff 8905

View Options

source/blender/makesrna/intern/rna_particle.c

Fix for T51289ClosedPublicActions