Page MenuHome
Differential D2705

Cycles: Adjust split kernel tile updating logic
Needs ReviewPublic
Actions

Authored by Mai Lavelle (maiself) on Jun 8 2017, 10:25 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Hristo Gueorguiev (nirved)
Summary

This makes tiles update less frequently and causes there to be more samples in each batch making rendering faster. This helps a bit with the slowdown seen from D2703.

I don't really like tiles not updating as much, it feels much less responsive, maybe theres another way to go about it?

Timings by @Hristo Gueorguiev (nirved): https://hastebin.com/ifanihewum.css

Diff Detail

Event Timeline

Mai Lavelle (maiself) created this revision.Jun 8 2017, 10:25 AM
Sergey Sharybin (sergey) edited edge metadata.Jun 8 2017, 10:38 AM

How exactly less frequent updates are happening?

intern/cycles/device/device_split_kernel.cpp
198

If it's time between updates, the n`time_multiplier` is a bad name here.

intern/cycles/render/session.h
164

If we are introducing this, we should get rid of BlenderSession::headless.

Mai Lavelle (maiself) added a comment.Jun 8 2017, 11:39 AM
In D2705#63655, @Sergey Sharybin (sergey) wrote:

How exactly less frequent updates are happening?

Previously for each tile updates would happen at 1 sec, then 2 sec, 4 sec, 8 sec, 10 sec, 10 sec, etc.

With this they happen at ~1 sec, ~10 sec, ~10 sec etc

Revision Contents
Changeset List

PathSize
intern/
cycles/
app/
2 lines
2 lines
blender/
2 lines
device/
36 lines
render/
2 lines
2 lines

Diff 8912

View Options

intern/cycles/app/cycles_server.cpp

Loading...
View Options

intern/cycles/app/cycles_standalone.cpp

Loading...
View Options

intern/cycles/blender/blender_session.cpp

Loading...
View Options

intern/cycles/device/device_split_kernel.cpp

Loading...
View Options

intern/cycles/render/session.h

Loading...
View Options

intern/cycles/render/session.cpp

Loading...