Page MenuHome
Differential D2729

Improve trackball rotation mode by using a single axis
ClosedPublic
Actions

Authored by Igor Malovitsa (IgorNull) on Jun 27 2017, 10:41 PM.

Details

Reviewers
Aaron Carlisle (Blendify)
Campbell Barton (campbellbarton)
Summary

Currently, trackball rotation sequentially applies rotation across x axis and y axis, which produces weird results when mouse pointer is moving diagonally:

https://gfycat.com/WealthyQuaintBovine

If rotation is combined properly, this problem does not happen:

https://gfycat.com/IndolentZigzagGroundbeetle

This change fixes the problem by using a single axis which is orthogonal and proportional to mouse delta.

Diff Detail

Repository
rB Blender

Event Timeline

Igor Malovitsa (IgorNull) created this revision.Jun 27 2017, 10:41 PM
Igor Malovitsa (IgorNull) created this object with edit policy "Igor Malovitsa (IgorNull)".
Pablo Vazquez (pablovazquez) awarded a token.Jun 27 2017, 10:52 PM
Pablo Vazquez (pablovazquez) added a subscriber: Pablo Vazquez (pablovazquez).
Aaron Carlisle (Blendify) added subscribers: Campbell Barton (campbellbarton), Aaron Carlisle (Blendify).Jun 28 2017, 12:20 AM

@Campbell Barton (campbellbarton) can you take a look?

nekk (nekk) awarded a token.Jun 28 2017, 2:49 AM
nekk (nekk) added a subscriber: nekk (nekk).
Campbell Barton (campbellbarton) mentioned this in rB9210a4faf38f: Fix unpredictable trackball rotation.Jun 30 2017, 3:04 AM
Campbell Barton (campbellbarton) accepted this revision.Jun 30 2017, 3:43 AM

Very nice! committed rB9210a4faf38f675582ea7a080d5fbaea0e90d493

This revision is now accepted and ready to land.Jun 30 2017, 3:43 AM
Campbell Barton (campbellbarton) resigned from this revision.Jun 30 2017, 3:45 AM
Campbell Barton (campbellbarton) edited projects, added BF Blender; removed User Interface.
This revision now requires review to proceed.Jun 30 2017, 3:45 AM
Campbell Barton (campbellbarton) removed a project: BF Blender.Jun 30 2017, 3:47 AM

This diff should be closed. (for some reason I don't see the option)

Aaron Carlisle (Blendify) added a comment.Jun 30 2017, 4:18 AM

@Igor Malovitsa (IgorNull) please do not change the edit policy can you go to: Add Action --> Close Revision. Thanks.

Igor Malovitsa (IgorNull) added a comment.Jun 30 2017, 9:03 AM
In D2729#64205, @Aaron Carlisle (Blendify) wrote:

@Igor Malovitsa (IgorNull) please do not change the edit policy can you go to: Add Action --> Close Revision. Thanks.

No, I can not. I don't have "Close Revision" available in the "Add Action" action list.
Should I change the edit policy to allow admins to edit this revision?

Aaron Carlisle (Blendify) added a comment.Jun 30 2017, 3:27 PM

Or any user as we only have a small group with admin rights and they are usually too busy.

Igor Malovitsa (IgorNull) changed the edit policy from "Igor Malovitsa (IgorNull)" to "All Users".Jun 30 2017, 3:27 PM
Aaron Carlisle (Blendify) accepted this revision.Jun 30 2017, 9:34 PM
This revision is now accepted and ready to land.Jun 30 2017, 9:34 PM
Aaron Carlisle (Blendify) closed this revision.Jun 30 2017, 9:34 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
transform/
17 lines

Diff 8971

View Options

source/blender/editors/transform/transform.c

Loading...