Differential D2749

MeasureIt bug fix and redesign
ClosedPublic
Actions

Authored by nBurn (nBurn) on Jul 25 2017, 11:35 PM.

Details

Reviewers

Antonio Vazquez (antoniov)

Maniphest Tasks

T52166: MeasureIt: 2 bugs in Mesh Debug option

Summary

The patch fixes the following bugs listed in T52166: MeasureIt: 2 bugs in Mesh Debug option:

Added checks in draw_segments(), draw_text(), and draw_arrow() to make sure they do not attempt to subscript a NoneType
Made so the "Location" button in "Mesh Debug" panel still works when "Vertices" option is disabled

Additional changes:

Added conditionals to not show "Thickness" option in "Mesh Debug" panel unless "Normals" option is checked (Thickness only affects arrows drawn with normal option)
Added conditionals to not hide "Arrow Size" option in Properties panel when arrow options weren't enabled
Reorganized Mesh Debug panel layout to align colours with displayed values they are connected with
Added an option to change between global and local coordinates for vertices
Added an option to display edge index values (requested by meta-androcto)
Added an option to display object scene index values and object coordinates

Diff Detail

Repository: rBA Blender Add-ons

Event Timeline

nBurn (nBurn) created this revision.Jul 25 2017, 11:35 PM

nBurn (nBurn) added a task: T52166: MeasureIt: 2 bugs in Mesh Debug option.Jul 25 2017, 11:39 PM

nBurn (nBurn) mentioned this in T52166: MeasureIt: 2 bugs in Mesh Debug option.Jul 25 2017, 11:47 PM

I have tested and I think you can go ahead with this patch. Really you have done a great job adding a lot of useful functionalities.

Try to commit yourself, and if you cannot, contact with @Brendon Murphy (meta-androcto) to commit (I don't know how commit with different commiter and author)

Thanks!

This revision is now accepted and ready to land.Jul 26 2017, 10:34 AM

@nBurn (nBurn) is this committed and can be closed? Thanks.