Page MenuHome

DPI: add back option to control line width, tweak default width.
ClosedPublic

Authored by Brecht Van Lommel (brecht) on Aug 7 2017, 11:03 PM.

Details

Summary

Adds thin/default/thick modes to add -1/0/1 to the auto detected line width,
while leaving the overall UI scale unchanged.

Also tweaks the default line width threshold, so thicker lines start from
slightly high UI scales.

Diff Detail

Repository
rB Blender

Event Timeline

If there are also issues with font rendering on Windows being worse than 2.78c, then that will need more evidence to clarify what that means (like a screenshot). Because I can't see how that would happen given the implementation and my own testing on Windows.

Sergey Sharybin (sergey) requested changes to this revision.Aug 8 2017, 11:26 AM
Sergey Sharybin (sergey) added inline comments.
source/blender/makesrna/intern/rna_userdef.c
3309

I am not sure Default is a good name, especially since you don't explain what it is in a tooltip. It is something which is auto-magically detected by our system.

It is more like Native, assuming it behaves similar to old system where we've initalized line width based on whether it's retina or regular display.

Better name is possible, and surely descriptions are needed.

source/blender/windowmanager/intern/wm_window.c
409–411

You can't and should not be doing this. MAX2() is a macro, which creates some temp variables to control types. This causes compilation error on Linux due to shadowing variables. And on all platforms you'll have right side of outer MAX2 evaluated twice and that is not a cheap calculation.

Just use max_ii here, will solve lots of issues.

This revision now requires changes to proceed.Aug 8 2017, 11:26 AM
Brecht Van Lommel (brecht) edited edge metadata.

Address review comments.

Well, technically the old functionality is back, just defined in different words.

As for the default font rendering on Windows we'll hook up some machine to 4K screen we've got and see if we can reproduce issue here. During SIGGRAPH default interface was looking horrible on the screen we had there.

This revision is now accepted and ready to land.Aug 10 2017, 10:04 AM
This revision was automatically updated to reflect the committed changes.