Differential D285
Add transparency support to tabs Authored by Campbell Barton (campbellbarton) on Feb 3 2014, 8:13 PM.
Details
This adds transparency support for each of the tab theme colors. In addition it disables the tab highlight as it was generally distracting and it loons much cleaner without it. It also adds a secondary outline to the active tab to ensure good readability with transparent tabs. This secondary tab also makes the design feel more consistent with the tab divider. Original patch by @codemanx Single Patch Download:
Diff Detail
Event TimelineComment Actions @Campbell Barton (campbellbarton) would you be game to review this? I believe you mentioned a while ago that transparency had some unforeseen problems, but I can't seem to find any. Seems to be working very well. My main question is how much it impacts speed. Is there a good way to test this? Comment Actions @Jonathan Williamson (carter2422) - Ill check on this - minor note inline, but I can probably change when applying the patch, so only make these changes if you want. Id like to do final review before committing though, whatever happens,
Comment Actions
Comment Actions
Comment Actions Not really a fan of removing highlight - and not clear why this is done, would prefer to just add alpha support and do any visual changes as a separate patch - but before that, have some agreement on whats wrong with the tabs and why they should change. Comment Actions
Comment Actions
Comment Actions @Campbell Barton (campbellbarton), any qualms with the latest version? It only adds alpha support and doesn't affect anything else (the patch linked in the OP is slightly out of date, just check last revision).
Comment Actions @Jonathan Williamson (carter2422) - the problem with the highlight is blend_color_interpolate_byte has special handling of alpha, in this case I think we're best off to use simple lerp interpolation of RGB and ignore alpha. updating patch now... will commit if its ok. Comment Actions Committed a very much cut down version of this patch: rB3276b83fda1e49bd007872c8dcd0f1b4c62063a3 To get this all working with alpha seems a lot more involved then you might think, further - Im skeptical of transparency with the tabs themselves, you too easily get interference with the 3d scene or image behind. Got the highlight issue solved by using a simpler color blending function which ignores alpha. but didnt commit. For now, I rather not spend anymore time on this, its quite tricky to get it working really well, and if we want good alpha for this we probably want to have some nice blending between tabs the region background. Related to this patch - you did raise an issue that tabs dont work nice with dark themes, I checked elysuin theme and it looks OK to me, but if you think there is still issues IMHO we could check on them before 2.70 release. Comment Actions Sounds good @Campbell Barton (campbellbarton). Agreed, let's not spend any more time on this for now. re: dark themes, the issue here was with the highlight blending. It sounds like using the simpler interpolation method might do the trick. So that would tentatively solve both highlight strength issue and the dark themes. The main outstanding issue that I'd like to get solved somehow (perhaps with blending between the Region Background and Tabs, like you said) is the difference between tabs and the region background when the region is transparent This may be wrong, but I believe the active tab at least should always match the region background. As you've said before, though, this becomes more challenging since the tab area is over the region, not next to it. I suggest we try and solve this in 2.71 or so. Thanks! Comment Actions Sounds like we're on the same page. committed simple color blending (was silly we didnt have a way to do that). so at least we won't run into weird alpha behavior again. | ||||||||||||||||||||