Details

Reviewers

Thomas Dinges (dingto)
Sergey Sharybin (sergey)

Summary

Texture Node for Gabor Noise Method Band-Limited Isotropic only.

gabor_noise.patch24 KBDownload

Diff Detail

Repository: rB Blender
Branch: arcpatch-D287

Event Timeline

Gabor Noise Texture Node

Revised submit of diff with arc as previously new files were not added.

changes to dereferencing etc

Resolved issue with random number being out of range which resulted in

Initial code and style review. Haven't tested the functionality yet.

Also the patch is missing the .osl shader file.

BUILD_NOTES.txt
3 ↗	(On Diff #1196)	This file should not be in the patch.
intern/cycles/kernel/svm/svm_noise.h
392	This is not needed after all, svm_noise.h already has this OSL compatible header and we should only have 1 licence header per file. You can keep the 3 lines with gabornoise.com link of course.
424	No need to re-declare this, you can remove the #ifndef KERNEL_SSE2 on top of this file, so quick_floor() is available for both Perlin and Gabor.
467	Whitespace, no need for these empty lines. :) There are more unneeded white lines beneath too.
523	Completely upper-case variables should only be used for Definitions, not regular variables. Also I guess you can use float variants of the math defines, we have our own M_PI_F for example.
538	Use M_PI_F here too, to avoid the cast.
intern/cycles/render/nodes.cpp
797	Value: We use "Fac" as name for these outputs, short form of "Factor". This should be consistent with other nodes.
source/blender/gpu/intern/gpu_codegen.c
1203 ↗	(On Diff #852)	Why was that changed?
source/blender/nodes/shader/nodes/node_shader_tex_gabor.c
43	"Fac" must be changed here too.
64	If you do this here, you should create a stab function in source\blender\gpu\shaders\gpu_shader_material.glsl, same like "node_tex_checker" or so.

Ignore the comment about gpu_codegen.c, this is not in the latest patch anymore.

Changes made according to DingTo review:

gabor.diff40 KBDownload

Did some cleanup and renamed "Impulse" to "Impulses" in the UI, I think we should use the plural here.

ToDo:

OSL shader is still missing.
CUDA does not compile with this.

gabor.diff21 KBDownload

Last patch had line endings messed up, sorry.

Applied suggested optimisations

Sergey Sharybin (sergey) added a reviewer: Sergey Sharybin (sergey).Feb 4 2015, 9:12 PM

This revision now requires changes to proceed.Feb 4 2015, 9:12 PM

Charlie Jolly (charlie) mentioned this in D3495: Node: Gabor Noise Texture (WIP).Jun 21 2018, 5:34 PM

Emi Martinez (EmiMartinez) awarded a token.Sep 14 2022, 5:32 AM

Emi Martinez (EmiMartinez) added a subscriber: Emi Martinez (EmiMartinez).

any image associated with this noise?

http://maverick.inria.fr/~Romain.Vergne/blog/data/research/fast-gabor-noise-image.jpg

Gabor Noise Texture Node
Needs RevisionPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1271

intern/cycles/app/cycles_xml.cpp

intern/cycles/blender/blender_shader.cpp

intern/cycles/kernel/svm/svm.h

intern/cycles/kernel/svm/svm_gabortex.h

intern/cycles/kernel/svm/svm_noise.h

intern/cycles/kernel/svm/svm_types.h

intern/cycles/render/nodes.h

intern/cycles/render/nodes.cpp

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/intern/node.c

source/blender/gpu/shaders/gpu_shader_material.glsl

source/blender/makesdna/DNA_node_types.h

source/blender/makesrna/intern/rna_nodetree.c

source/blender/nodes/CMakeLists.txt

source/blender/nodes/NOD_shader.h

source/blender/nodes/NOD_static_types.h

source/blender/nodes/shader/nodes/node_shader_tex_gabor.c

Gabor Noise Texture NodeNeeds RevisionPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1271

intern/cycles/app/cycles_xml.cpp

intern/cycles/blender/blender_shader.cpp

intern/cycles/kernel/svm/svm.h

intern/cycles/kernel/svm/svm_gabortex.h

intern/cycles/kernel/svm/svm_noise.h

intern/cycles/kernel/svm/svm_types.h

intern/cycles/render/nodes.h

intern/cycles/render/nodes.cpp

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/intern/node.c

source/blender/gpu/shaders/gpu_shader_material.glsl

source/blender/makesdna/DNA_node_types.h

source/blender/makesrna/intern/rna_nodetree.c

source/blender/nodes/CMakeLists.txt

source/blender/nodes/NOD_shader.h

source/blender/nodes/NOD_static_types.h

source/blender/nodes/shader/nodes/node_shader_tex_gabor.c

Gabor Noise Texture Node
Needs RevisionPublic
Actions

Revision Contents
Changeset List