The name is somewhat unintuitive I guess.
Details
Details
- Reviewers
Sergey Sharybin (sergey) Brecht Van Lommel (brecht) - Commits
- rBS322f0223d04a: Cycles: option to make background visible through glass transparent.
rCed420fad1ee1: option to make background visible through glass transparent.
rB322f0223d04a: Cycles: option to make background visible through glass transparent.
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
I like the general idea, but if you don't mind I'll make some tweaks/optimizations in the implementation.
Comment Actions
- Small optimizations, mainly using new LABEL_TRANSMIT_TRANSPARENT to avoid passing around roughness.
- Make it work with shadow catcher (and holdout) behind glass. This feature will often be used together with a shadow catcher.
- Fill environment (background) pass behind transparent glass, so that it can be composited back in to get the complete render.
- Split into two properties "Transparent Glass" and "Roughness Threshold" (defaulting to 0.1), to try to make the UI more intuitive.
- Use squared roughness for the threshold like the principled BSDF. For 2.8 we should change the other BSDFs to this roughness convention as well, we might as well use it already as there is no way to be consistent with all BSDFs.
| intern/cycles/kernel/closure/bsdf.h | ||
|---|---|---|
| 41 | Either call it bsdf_get_square_roughness which is explicit and easy to read, or follow general Blender style and use _sq. Would really suggest the first one. | |
| 178 | You can not assign non-square value to a square one. Surely, kernel_data.background.transparent_roughness_threshold is likely storing squared value, but this is not what the name suggests and this line reads as a bug. | |