Blender 2.8: Mesh Auto-Smooth Split Normal Support
AbandonedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Oct 31 2017, 1:04 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Dalai Felinto (dfelinto)
Clément Foucault (fclem)

Summary

This is a partial solution to the task T51604.

Only suports auto-smooth for Meshs (not Edit-Meshs)

A special attention must be paid to rdata->poly_normals. It may be better to use a CustomData than to allocate and release every time that the smoot_angle changes.

Other more efficient solutions could be:

Update VBO only;
Use the glBufferSubData to update just a subset of the object's buffer data;

Feel free to edit and/or commit the patch ;)

Diff Detail

Repository: rB Blender

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Oct 31 2017, 1:04 PM

Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Oct 31 2017, 1:16 PM

Generally LGTM, one concern.

source/blender/draw/intern/draw_cache_impl_mesh.c
460	Are you sure this isn't saved into the file? I think you may need to set `CD_FLAG_TEMPORARY`

Germano Cavalcante (mano-wii) mentioned this in rB59f238ba0911: Mesh Auto-Smooth Split Normal Support.Oct 31 2017, 6:15 PM

Committed rB59f238ba0911
(with some changes)

A comment on the final committed code:
If the comment: /* TODO: split normals, see below */ is no longer relevant, please get rid of it.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

draw_cache_impl_mesh.c

49 lines

Diff 9491

View Options

source/blender/draw/intern/draw_cache_impl_mesh.c

Blender 2.8: Mesh Auto-Smooth Split Normal SupportAbandonedPublicActions