Fix `bl_idname` in HiRISE DTM Importer
ClosedPublic
Actions

Authored by Nicholas Wolf (nicwolf) on Nov 20 2017, 8:30 PM.

Details

Reviewers

Vuk Gardašević (lijenstina)
Brendon Murphy (meta-androcto)

Summary

A user noticed that this importer was not working when accessed through the Python bpy.ops API. The ImportHelper's bl_idname causes Blender to unsuccessfully attempt to place it in the bpy.ops.import namespace. This patch fixes the issue by correcting the bl_idname to place it in the bpy.ops.import_mesh namespace.

Diff Detail

Repository: rBA Blender Add-ons

Event Timeline

Nicholas Wolf (nicwolf) created this revision.Nov 20 2017, 8:30 PM

Aaron Carlisle (Blendify) added reviewers: Vuk Gardašević (lijenstina), Brendon Murphy (meta-androcto).Nov 21 2017, 5:44 PM

Thanks for the patch and spotting the issue.

To clarify things, it's not related to The ImportHelper's bl_idname (as ImportHelper is just a python class with bells and whistles used for inheritance) but how across Blender the operator namespace is generated (bpy.ops. + bl_idname).
It would happen with any operator having import between dots as it is a reserved word in Python.

This revision is now accepted and ready to land.Nov 24 2017, 1:05 PM

Vuk Gardašević (lijenstina) mentioned this in rBA0ec059ad19b8: HiRISE DTM Importer: Fix operator call through Python, minor cleanup.Nov 27 2017, 6:25 AM

Committed rBA0ec059ad19b8 with modifications. Thanks :)

Bastien Montagne (mont29) mentioned this in rBAdd9965f37c3b: HiRISE DTM Importer: Fix operator call through Python, minor cleanup.Jan 6 2018, 4:43 PM