Issue T53321 resolved
Needs RevisionPublic
Actions

Authored by José Luis Oliveira Cunha (JoseCunha) on Dec 6 2017, 1:25 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Lukas Stockner (lukasstockner97)
Brecht Van Lommel (brecht)
Sybren A. Stüvel (sybren)

Maniphest Tasks

T53321: "Z" changed to "depth" breaks consistency in compositing and in Render layers

Summary

The error: "Z" changed to "Depth" breaks consistency in compositing and in Render layers.

Resolving the problem:
Assigning different value ("Z") to the constant 'RE_PASSNAME_Z' defined with “Depth” in the header file 'DNA_ scene_types.h' in project 'bf_dna'.

Diff Detail

Repository: rB Blender

Event Timeline

José Luis Oliveira Cunha (JoseCunha) created this revision.Dec 6 2017, 1:25 PM

José Luis Oliveira Cunha (JoseCunha) created this object with edit policy "Administrators".

José Luis Oliveira Cunha (JoseCunha) added a task: T53321: "Z" changed to "depth" breaks consistency in compositing and in Render layers.Dec 6 2017, 1:46 PM

What i'm afraid here is that applying this fix will break files created after the buggy commit was done before this fix is applied. Probably some do-versions is required.

@José Luis Oliveira Cunha (JoseCunha), did you check that there is no compatibility loss here?

@Lukas Stockner (lukasstockner97) , this is a patch for a change in area you broke.

P.S. Setting to "Request Changes" since some action is required from the author.

This revision now requires changes to proceed.Dec 6 2017, 2:36 PM

Sybren A. Stüvel (sybren) resigned from this revision.Dec 7 2017, 3:56 PM

Thomas Dinges (dingto) changed the edit policy from "Administrators" to "All Users".Feb 2 2022, 6:07 PM

Ankit Meel (ankitm) removed reviewers: Compositing, BF Blender.Feb 2 2022, 6:09 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

makesdna/

	DNA_scene_types.h
	DNA_scene_types.h

2 lines

Diff 9648

View Options

source/blender/makesdna/DNA_scene_types.h

Issue T53321 resolvedNeeds RevisionPublicActions