Fix T52966: First button different with sizes compared to others in block
AbandonedPublic
Actions

Authored by Francisco Silva (francisjssilva) on Dec 12 2017, 9:07 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Julian Eisel (Severin)

Maniphest Tasks

T52966: First button is always 18 px (should be 19 px)

Summary

We solved this issue even though it's a bit hardcoded.

Fixes T52966

Diff Detail

Repository: rB Blender

Event Timeline

Francisco Silva (francisjssilva) created this revision.Dec 12 2017, 9:07 PM

Aaron Carlisle (Blendify) retitled this revision from First button different with sizes compared to others in block - Issue T52966 resolved to Fix T52966: First button different with sizes compared to others in block.Dec 13 2017, 1:26 AM

Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)

Aaron Carlisle (Blendify) edited reviewers, added: Campbell Barton (campbellbarton), Julian Eisel (Severin); removed: User Interface, BF Blender.

Aaron Carlisle (Blendify) added a task: T52966: First button is always 18 px (should be 19 px).

Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).Dec 13 2017, 11:42 AM

Sergey Sharybin (sergey) added inline comments.

extern/bullet2/src/BulletCollision/BroadphaseCollision/btAxisSweep3.cpp
21	That seems to be irrelevant.

Thanks for looking into this, but the root cause should really be fixed in this case.

If it were important we could apply anyway - but this is such a subtle issue, we better fix properly or not at all.

This revision now requires changes to proceed.Dec 13 2017, 11:44 AM

No activity for a long time, abandoned as there should be a fix for all cases, see https://developer.blender.org/D4063#248008

Revision Contents
Changeset List

Path

Size

extern/

bullet2/

src/

BulletCollision/

BroadphaseCollision/

btAxisSweep3.cpp

1 line

source/

blender/

editors/

interface/

interface_panel.c

24 lines

Diff 9663

View Options

extern/bullet2/src/BulletCollision/BroadphaseCollision/btAxisSweep3.cpp