Fix T53442: Outliner refreshes fine after adding new collection now.
AbandonedPublic
Actions

Authored by Danrae Pray (spockTheGray) on Dec 19 2017, 2:50 AM.

Details

Reviewers

Julian Eisel (Severin)
Dalai Felinto (dfelinto)

Maniphest Tasks

T53442: Outliner: Drawing doesn't refresh after adding a new collection

Summary

Fix T53442: Outliner refreshes fine after adding new collection now.

Just needed to set the treestore flag properly.

Diff Detail

Repository

rB Blender

Branch

spock-T53442_1

Build Status

Buildable 1039
Build 1039: arc lint + arc unit

Event Timeline

Danrae Pray (spockTheGray) created this revision.Dec 19 2017, 2:50 AM

Danrae Pray (spockTheGray) edited the summary of this revision. (Show Details)Dec 19 2017, 2:51 AM

Danrae Pray (spockTheGray) added reviewers: Julian Eisel (Severin), Dalai Felinto (dfelinto).

Danrae Pray (spockTheGray) added a project: BF Blender: 2.8.

Danrae Pray (spockTheGray) added a task: T53442: Outliner: Drawing doesn't refresh after adding a new collection.

Although this works, this is not used elsewhere. Is this really the only way to force the outliner tree to update?

Fix T53442: fixed treestore flag from previous commit - cleanup wasn't required

Same thing I said about CLEANUP, although REBUILD works we don't use it anywhere else. Why is the notification system working for this case? Why do we need to resort to "extreme" measures such as this?

I think we should call outliner_cleanup_tree(soops); see other instances of when this is called. Their comments explain what is going on.

Committed something similar on b3bcbc9e85aa.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_outliner/

outliner_collections.c

3 lines

Diff 9715

View Options

source/blender/editors/space_outliner/outliner_collections.c

Fix T53442: Outliner refreshes fine after adding new collection now.AbandonedPublicActions