Fix Luma Matte Node not allowing displaying display referred values
ClosedPublic
Actions

Authored by Aaron Carlisle (Blendify) on Dec 30 2017, 11:19 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)
Lukas Stockner (lukasstockner97)

Commits

rBSadd580beeea0: Fix T47212: Luminance Key not working with HDR and out-of-gamut ranges.
rB13973a5bbf35: Fix T47212: Luminance Key not working with HDR and out-of-gamut ranges.
rBadd580beeea0: Fix T47212: Luminance Key not working with HDR and out-of-gamut ranges.

Summary

Partial fix of T47212

This patch also allows the selection of negative values not that this comes up often in a typical workflow but can happen on color space conversions or when people set negative luminance values in the UI.

Test file:

bug_luma_matte.blend485 KBDownload

Diff Detail

Event Timeline

Aaron Carlisle (Blendify) created this revision.Dec 30 2017, 11:19 PM

Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)

Fix wrong max ui max value

Looks fine to me, but remove the calls to RNA_def_property_range since they are just setting the default again.

Remove calls to RNA_def_property_range

Brecht Van Lommel (brecht) accepted this revision.Jan 1 2018, 3:19 AM

This revision is now accepted and ready to land.Jan 1 2018, 3:19 AM

Closed by commit rBadd580beeea0: Fix T47212: Luminance Key not working with HDR and out-of-gamut ranges. (authored by Aaron Carlisle (Blendify), committed by Brecht Van Lommel (brecht)). · Explain WhyJan 6 2018, 4:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_nodetree.c

6 lines

Diff 9744

View Options

source/blender/makesrna/intern/rna_nodetree.c

Fix Luma Matte Node not allowing displaying display referred valuesClosedPublicActions