As seen on the internet:
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Updated, as I noticed the node on the image was actually a 'Texture Image' node instead of 'Image'. Both should work now :)
Comment Actions
Small nit-picking about comment style. Such a small patch indeed :)
| source/blender/blenkernel/intern/node.c | ||
|---|---|---|
| 3185 | - /* The previous methods (labelfunc) could not provide an adequate label for the node */ + /* The previous methods (labelfunc) could not provide an adequate label for the node. */ | |
| source/blender/nodes/intern/node_util.c | ||
| 96 ↗ | (On Diff #9764) | - /* if there is no loaded image, return an empty string, and let nodeLabel() fill in the proper type translation */ + /* If there is no loaded image, return an empty string, and let nodeLabel() fill in the proper type translation. */ |
Comment Actions
Okay, call me a noob, but I made the changes, built and I don't see that action on macOs.
Screenshots from Xcode :
Comment Actions
Patch LGTM, and feature makes sense imho.
As @Dalai Felinto (dfelinto) noted, we try to have fully valid sentences in our comments, including end points, see also https://wiki.blender.org/index.php/Dev:Doc/Code_Style#Comments ;)
Comment Actions
Submitted 87607254d6d
@Joel Godin (FloridaJo) maybe you have a problem in your setup? Can you see any other changes that you make? Drop by IRC #blendercoders if you need help setting up or getting patches with arcanist!
Comment Actions
I basically cloned the repository, made changes to the individual files and then built.
After building and not seeing the change, I reexamined the individual files in Xcode (pics above) and the changes are definitely there.