Paths

Table of Contentst

Differential D3003

PoC: Sample based compositor
AbandonedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jan 15 2018, 2:01 PM.

Details

Reviewers

None

Group Reviewers

Maniphest Tasks

T53790: Design Doc: Sample based compositor

Summary

See T53790 for discussion

Note: still very WIP. eg crash-a-lot it is intended to be a proof of concept. not actual for code review

Original repository
Bitbucket source repository: https://bitbucket.org/atmind/blender-compositor-2016 branch compositor-2016

Nodes that have implementation (not guaranteed 100% same):
Viewer, RGB, Value, Mix, AlphaOver, Image (no OpenEXR), Render layers, Movieclip, Blur (only relative and bokeh), Color Matte, Chroma matte, Math, Value to Color, Value to Vector, Vector to Value, Color to Value, Color to Vector, RGB to BW, Separate RGBA/HSVA/YUVA, Combine RGBA/HSVA/YUVA, Hue Sat, Bright contrast, Gamma, Color balance, Color spill, Set Alpha, Channel matte, Difference Matte, Distance Matte, Luma Matte

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Jan 15 2018, 2:01 PM

Jeroen Bakker (jbakker) added a reviewer: Compositing.Jan 15 2018, 2:03 PM

Steffen Dünner (SteffenD) added a subscriber: Steffen Dünner (SteffenD).Jan 15 2018, 2:08 PM

Jeroen Bakker (jbakker) added a task: T53790: Design Doc: Sample based compositor.Jan 15 2018, 2:19 PM

Jeroen Bakker (jbakker) retitled this revision from Design Doc: Sample based compositor to PoC: Sample based compositor.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jan 15 2018, 2:29 PM

Erick Tukuniata (erickblender) added a subscriber: Erick Tukuniata (erickblender).Jan 15 2018, 2:50 PM

Very interesting! I checked it out (both compositor-2106 and compositor-2016-macosand on macOS it simply crashes after basic interaction (plugging in a viewer node). Attached you find some logs, I hope it helps.

comp_startup.txt571 KBDownload

comp_crash.txt2 KBDownload

Please don't remove whitespace it makes looking for real changes and nightmare

source/blender/compositor/nodes/COM_MovieClipNode.cpp
15	This file contains meaning less changes

Michael P. (forest-house) added a subscriber: Michael P. (forest-house).Jan 15 2018, 11:15 PM

Jeroen Bakker (jbakker) abandoned this revision.Mar 25 2019, 1:40 PM

Large Diff

This large diff affects 187 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

1 line

properties_data_viewport.py

62 lines

16 lines

source/

blender/

1 line

blenkernel/

2 lines

1 line

46 lines

2 lines

intern/

1 line

2 lines

16 lines

library_remap.c

5 lines

3 lines

82 lines

blenloader/

intern/

19 lines

versioning_280.c

67 lines

17 lines

blentranslation/

BLT_translation.h

1 line

compositor/

640 lines

COM_compositor.h

300 lines

4 lines

cmp/

cmp_compositor.cpp

115 lines

119 lines

90 lines

cmp_nodesocket.hpp

27 lines

cmp_nodesocket.cpp

125 lines

37 lines

111 lines

cmp_rendercontext.hpp

44 lines

cmp_tilemanager.hpp

24 lines

cmp_tilemanager.cpp

137 lines

11 lines

30 lines

compiler/

cmp_compiler.hpp

111 lines

cmp_compiler.cpp

462 lines

make_program.hpp

9 lines

make_program.cpp

640 lines

mem_block_manager.hpp

24 lines

mem_block_manager.cpp

63 lines

nodetree_optimizer.hpp

9 lines

nodetree_optimizer.cpp

120 lines

device/

74 lines

148 lines

77 lines

139 lines

device_opencl.hpp

104 lines

device_opencl.cpp

420 lines

device_task.hpp

47 lines

device_task.cpp

31 lines

memory_manager.hpp

96 lines

memory_manager.cpp

141 lines

intern/

COM_compositor.cpp

6 lines

kernel/

10 lines

kernel_compat_cpu.h

4 lines

kernel_compat_opencl.h

4 lines

kernel_globals.h

73 lines

319 lines

kernel_random.h

9 lines

17 lines

kernel_viewport.h

104 lines

kernels/

cpu/

7 lines

4 lines

kernel_cpu_avx.cpp

5 lines

kernel_cpu_avx2.cpp

5 lines

kernel_cpu_defines.h

26 lines

kernel_cpu_impl.h

21 lines

kernel_cpu_sse2.cpp

5 lines

kernel_cpu_sse3.cpp

5 lines

kernel_cpu_sse41.cpp

5 lines

32 lines

opencl/

kernel_opencl.cl

35 lines

kernel_opencl_defines.h

22 lines

operations/

op_alpha_over.h

28 lines

41 lines

16 lines

op_brightness_contrast.h

30 lines

4 lines

op_color_spill.h

78 lines

op_colorbalance_cdl.h

27 lines

op_colorbalance_lgg.h

27 lines

op_combine_hsva.h

10 lines

op_combine_rgba.h

10 lines

op_convert_color_to_value.h

1 line

op_convert_color_to_vector.h

2 lines

op_convert_value_to_color.h

4 lines

op_convert_value_to_vector.h

4 lines

op_convert_vector_to_color.h

2 lines

op_convert_vector_to_value.h

3 lines

14 lines

18 lines

op_image_float1.h

8 lines

op_image_float4.h

8 lines

168 lines

op_matte_channel.h

74 lines

op_matte_chroma.h

42 lines

op_matte_color.h

31 lines

op_matte_difference.h

14 lines

op_matte_distance_linear.h

17 lines

op_matte_distance_ycc.h

14 lines

op_matte_luminance.h

12 lines

48 lines

2 lines

op_output_ray.h

3 lines

op_separate_a.h

1 line

op_separate_b.h

1 line

op_separate_g.h

1 line

op_separate_h.h

1 line

op_separate_r.h

1 line

op_separate_s.h

1 line

op_separate_v.h

1 line

op_separate_yuv_u.h

1 line

op_separate_yuv_v.h

1 line

op_separate_yuv_y.h

1 line

6 lines

127 lines

2 lines

336 lines

nodes/

COM_MovieClipNode.cpp

14 lines

util/

util_algorithm.h

32 lines

util_aligned_malloc.h

32 lines

util_aligned_malloc.cpp

82 lines

91 lines

293 lines

util_guarded_allocator.h

189 lines

util_guarded_allocator.cpp

49 lines

524 lines

util_math_float2.h

235 lines

util_math_float3.h

374 lines

util_math_float4.h

419 lines

util_math_int2.h

77 lines

util_math_int3.h

83 lines

util_math_int4.h

119 lines

util_math_intersect.h

17 lines

util_optimization.h

121 lines

47 lines

32 lines

util_system.cpp

195 lines

24 lines

233 lines

util_types_float2.h

44 lines

util_types_float2_impl.h

59 lines

util_types_float3.h

61 lines

util_types_float3_impl.h

105 lines

util_types_float4.h

65 lines

util_types_float4_impl.h

117 lines

util_types_int2.h

43 lines

util_types_int2_impl.h

50 lines

util_types_int3.h

60 lines

util_types_int3_impl.h

106 lines

util_types_int4.h

65 lines

util_types_int4_impl.h

115 lines

util_types_uint2.h

43 lines

util_types_uint2_impl.h

48 lines

util_types_uint3.h

44 lines

util_types_uint3_impl.h

48 lines

util_types_uint4.h

44 lines

util_types_uint4_impl.h

48 lines

307 lines

util_viewport.h

54 lines

draw/

intern/

3 lines

41 lines

modes/

22 lines

editors/

object/

43 lines

object_intern.h

1 line

1 line

space_buttons/

buttons_context.c

7 lines

space_node/

348 lines

7 lines

space_outliner/

outliner_intern.h

2 lines

outliner_tree.c

9 lines

makesdna/

2 lines

DNA_node_types.h

42 lines

DNA_object_types.h

8 lines

DNA_viewport_types.h

64 lines

intern/

3 lines

makesrna/

1 line

RNA_enum_types.h

1 line

intern/

1 line

1 line

2 lines

1 line

43 lines

129 lines

1 line

85 lines

nodes/

composite/

nodes/

node_composite_image.c

45 lines

windowmanager/

intern/

1 line

Diff 9820

release/scripts/startup/bl_ui/init.py

release/scripts/startup/bl_ui/properties_data_viewport.py

release/scripts/startup/bl_ui/space_node.py

source/blender/CMakeLists.txt

source/blender/blenkernel/BKE_library.h

source/blender/blenkernel/BKE_main.h

source/blender/blenkernel/BKE_viewport.h

source/blender/blenkernel/CMakeLists.txt

source/blender/blenkernel/intern/anim_sys.c

source/blender/blenkernel/intern/idcode.c

source/blender/blenkernel/intern/library.c

source/blender/blenkernel/intern/library_remap.c

source/blender/blenkernel/intern/object.c

source/blender/blenkernel/intern/viewport.c

source/blender/blenloader/intern/readfile.c

source/blender/blenloader/intern/versioning_280.c

source/blender/blenloader/intern/writefile.c

source/blender/blentranslation/BLT_translation.h

source/blender/compositor/CMakeLists.txt

source/blender/compositor/COM_compositor.h

source/blender/compositor/COM_defines.h

source/blender/compositor/cmp/cmp_compositor.cpp

source/blender/compositor/cmp/cmp_node.hpp

source/blender/compositor/cmp/cmp_node.cpp

source/blender/compositor/cmp/cmp_nodesocket.hpp

source/blender/compositor/cmp/cmp_nodesocket.cpp

source/blender/compositor/cmp/cmp_output.hpp

source/blender/compositor/cmp/cmp_output.cpp

source/blender/compositor/cmp/cmp_rendercontext.hpp

source/blender/compositor/cmp/cmp_tilemanager.hpp

source/blender/compositor/cmp/cmp_tilemanager.cpp

source/blender/compositor/cmp/cmp_unroll.hpp

source/blender/compositor/cmp/cmp_unroll.cpp

source/blender/compositor/cmp/compiler/cmp_compiler.hpp

source/blender/compositor/cmp/compiler/cmp_compiler.cpp

source/blender/compositor/cmp/compiler/make_program.hpp

source/blender/compositor/cmp/compiler/make_program.cpp

source/blender/compositor/cmp/compiler/mem_block_manager.hpp

source/blender/compositor/cmp/compiler/mem_block_manager.cpp

source/blender/compositor/cmp/compiler/nodetree_optimizer.hpp

source/blender/compositor/cmp/compiler/nodetree_optimizer.cpp

source/blender/compositor/device/device.hpp

source/blender/compositor/device/device.cpp

source/blender/compositor/device/device_cpu.hpp

source/blender/compositor/device/device_cpu.cpp

source/blender/compositor/device/device_opencl.hpp

source/blender/compositor/device/device_opencl.cpp

source/blender/compositor/device/device_task.hpp

source/blender/compositor/device/device_task.cpp

source/blender/compositor/device/memory_manager.hpp

source/blender/compositor/device/memory_manager.cpp

source/blender/compositor/intern/COM_compositor.cpp

source/blender/compositor/kernel/kernel.h

source/blender/compositor/kernel/kernel_compat_cpu.h

source/blender/compositor/kernel/kernel_compat_opencl.h

source/blender/compositor/kernel/kernel_globals.h

source/blender/compositor/kernel/kernel_image.h

source/blender/compositor/kernel/kernel_random.h

source/blender/compositor/kernel/kernel_types.h

source/blender/compositor/kernel/kernel_viewport.h

source/blender/compositor/kernel/kernels/cpu/kernel_cpu.h

source/blender/compositor/kernel/kernels/cpu/kernel_cpu.cpp

source/blender/compositor/kernel/kernels/cpu/kernel_cpu_avx.cpp

source/blender/compositor/kernel/kernels/cpu/kernel_cpu_avx2.cpp

source/blender/compositor/kernel/kernels/cpu/kernel_cpu_defines.h

source/blender/compositor/kernel/kernels/cpu/kernel_cpu_impl.h

source/blender/compositor/kernel/kernels/cpu/kernel_cpu_sse2.cpp

source/blender/compositor/kernel/kernels/cpu/kernel_cpu_sse3.cpp

source/blender/compositor/kernel/kernels/cpu/kernel_cpu_sse41.cpp

source/blender/compositor/kernel/kernels/cpu/kernels.h

source/blender/compositor/kernel/kernels/opencl/kernel_opencl.cl

source/blender/compositor/kernel/kernels/opencl/kernel_opencl_defines.h

source/blender/compositor/kernel/operations/op_alpha_over.h

source/blender/compositor/kernel/operations/op_blur.h

source/blender/compositor/kernel/operations/op_blur_ray.h

source/blender/compositor/kernel/operations/op_brightness_contrast.h

source/blender/compositor/kernel/operations/op_color.h

source/blender/compositor/kernel/operations/op_color_spill.h

source/blender/compositor/kernel/operations/op_colorbalance_cdl.h

source/blender/compositor/kernel/operations/op_colorbalance_lgg.h

source/blender/compositor/kernel/operations/op_combine_hsva.h

source/blender/compositor/kernel/operations/op_combine_rgba.h

source/blender/compositor/kernel/operations/op_convert_color_to_value.h

source/blender/compositor/kernel/operations/op_convert_color_to_vector.h

source/blender/compositor/kernel/operations/op_convert_value_to_color.h

source/blender/compositor/kernel/operations/op_convert_value_to_vector.h

source/blender/compositor/kernel/operations/op_convert_vector_to_color.h

source/blender/compositor/kernel/operations/op_convert_vector_to_value.h

source/blender/compositor/kernel/operations/op_gamma.h

source/blender/compositor/kernel/operations/op_hsv.h

source/blender/compositor/kernel/operations/op_image_float1.h

source/blender/compositor/kernel/operations/op_image_float4.h

source/blender/compositor/kernel/operations/op_math.h

source/blender/compositor/kernel/operations/op_matte_channel.h

source/blender/compositor/kernel/operations/op_matte_chroma.h

source/blender/compositor/kernel/operations/op_matte_color.h

source/blender/compositor/kernel/operations/op_matte_difference.h

source/blender/compositor/kernel/operations/op_matte_distance_linear.h

source/blender/compositor/kernel/operations/op_matte_distance_ycc.h

source/blender/compositor/kernel/operations/op_matte_luminance.h

source/blender/compositor/kernel/operations/op_mix.h

source/blender/compositor/kernel/operations/op_output.h

source/blender/compositor/kernel/operations/op_output_ray.h

source/blender/compositor/kernel/operations/op_separate_a.h

source/blender/compositor/kernel/operations/op_separate_b.h

source/blender/compositor/kernel/operations/op_separate_g.h

source/blender/compositor/kernel/operations/op_separate_h.h

source/blender/compositor/kernel/operations/op_separate_r.h

source/blender/compositor/kernel/operations/op_separate_s.h

source/blender/compositor/kernel/operations/op_separate_v.h

source/blender/compositor/kernel/operations/op_separate_yuv_u.h

source/blender/compositor/kernel/operations/op_separate_yuv_v.h

source/blender/compositor/kernel/operations/op_separate_yuv_y.h

source/blender/compositor/kernel/operations/op_set_alpha.h

source/blender/compositor/kernel/operations/op_types.h

source/blender/compositor/kernel/operations/op_value.h

source/blender/compositor/kernel/operations/operations.h

source/blender/compositor/nodes/COM_MovieClipNode.cpp

Loading...

source/blender/compositor/util/util_algorithm.h

source/blender/compositor/util/util_aligned_malloc.h

source/blender/compositor/util/util_aligned_malloc.cpp

source/blender/compositor/util/util_atomic.h

source/blender/compositor/util/util_color.h

source/blender/compositor/util/util_guarded_allocator.h

source/blender/compositor/util/util_guarded_allocator.cpp

source/blender/compositor/util/util_math.h

source/blender/compositor/util/util_math_float2.h

source/blender/compositor/util/util_math_float3.h

source/blender/compositor/util/util_math_float4.h

source/blender/compositor/util/util_math_int2.h

source/blender/compositor/util/util_math_int3.h

source/blender/compositor/util/util_math_int4.h

source/blender/compositor/util/util_math_intersect.h

source/blender/compositor/util/util_optimization.h

source/blender/compositor/util/util_stats.h

source/blender/compositor/util/util_system.h

source/blender/compositor/util/util_system.cpp

source/blender/compositor/util/util_texture.h

source/blender/compositor/util/util_types.h

source/blender/compositor/util/util_types_float2.h

source/blender/compositor/util/util_types_float2_impl.h

source/blender/compositor/util/util_types_float3.h

source/blender/compositor/util/util_types_float3_impl.h

source/blender/compositor/util/util_types_float4.h

source/blender/compositor/util/util_types_float4_impl.h

source/blender/compositor/util/util_types_int2.h

source/blender/compositor/util/util_types_int2_impl.h

source/blender/compositor/util/util_types_int3.h

source/blender/compositor/util/util_types_int3_impl.h

source/blender/compositor/util/util_types_int4.h

source/blender/compositor/util/util_types_int4_impl.h

source/blender/compositor/util/util_types_uint2.h

source/blender/compositor/util/util_types_uint2_impl.h

source/blender/compositor/util/util_types_uint3.h

source/blender/compositor/util/util_types_uint3_impl.h

source/blender/compositor/util/util_types_uint4.h

source/blender/compositor/util/util_types_uint4_impl.h

source/blender/compositor/util/util_vector.h

source/blender/compositor/util/util_viewport.h

source/blender/draw/intern/draw_cache.h

source/blender/draw/intern/draw_cache.c

source/blender/draw/modes/object_mode.c

source/blender/editors/object/object_add.c

source/blender/editors/object/object_intern.h

source/blender/editors/object/object_ops.c

source/blender/editors/space_buttons/buttons_context.c

source/blender/editors/space_node/drawnode.c

source/blender/editors/space_node/node_edit.c

source/blender/editors/space_outliner/outliner_intern.h

source/blender/editors/space_outliner/outliner_tree.c

source/blender/makesdna/DNA_ID.h

source/blender/makesdna/DNA_node_types.h

source/blender/makesdna/DNA_object_types.h

source/blender/makesdna/DNA_viewport_types.h

source/blender/makesdna/intern/makesdna.c

source/blender/makesrna/RNA_access.h

source/blender/makesrna/RNA_enum_types.h

source/blender/makesrna/intern/CMakeLists.txt

source/blender/makesrna/intern/makesrna.c

source/blender/makesrna/intern/rna_ID.c

source/blender/makesrna/intern/rna_internal.h

source/blender/makesrna/intern/rna_main_api.c

source/blender/makesrna/intern/rna_nodetree.c

source/blender/makesrna/intern/rna_object.c

source/blender/makesrna/intern/rna_viewport.c

source/blender/nodes/composite/nodes/node_composite_image.c

source/blender/windowmanager/intern/wm_init_exit.c