Page MenuHome

Fix T53788: Camera animation not working
ClosedPublic

Authored by Sergey Sharybin (sergey) on Jan 18 2018, 4:02 PM.

Details

Summary

Both object level and camera datablock properties animation did not work with
copy on write enabled.

The root of the issue is going to the fact, that all interface elements are
referencing original datablock. For example, View3D has pointer to camera it's
using, and all areas which does access v3d->camera should in fact query for
the evaluated version of that camera, within the current context.

Annoying part of this change is that we now need to pass depsgraph in lots
of places. Which is rather annoying.

Alternative would be to cache evaluated camera in viewport itself, but then
it makes it annoying to keep things in sync.

Not sure if there is nicer solution here.

Diff Detail

Repository
rB Blender

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2018, 11:16 AM
This revision was automatically updated to reflect the committed changes.