fix T53841: FBX import: use replacement character when utf-8 decoding fails
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jan 20 2018, 12:02 PM.

Details

Reviewers

Summary

importer asserted in some places (but not the one in the report)
removed all asserts and used pythons 'replace' method mentioned in
https://docs.python.org/3/howto/unicode.html#the-string-type

Diff Detail

Repository: rBA Blender Add-ons

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jan 20 2018, 12:02 PM

Philipp Oeser (lichtwerk) mentioned this in T53841: Can not import .obj or .fbx generated from Marvelous Designer.Jan 20 2018, 12:05 PM

Philipp Oeser (lichtwerk) added a reviewer: Bastien Montagne (mont29).Jan 20 2018, 12:14 PM

Will apply the 'replace' option (even though, as already said, FBX strings should always only be utf-8 encoded), but really do not see why commenting out the asserts? Those should never ever be triggered, else file is really broken (or unsupported new-year fashion of FBX :( ).

This revision is now accepted and ready to land.Jan 22 2018, 9:51 AM

Bastien Montagne (mont29) mentioned this in rBA29ae03c572bd: Fix T53841: Can not import .obj or .fbx generated from Marvelous Designer.Jan 22 2018, 9:56 AM

Committed as rBA29ae03c572bd

Bastien Montagne (mont29) mentioned this in rBA580446555810: Fix T53841: Can not import .obj or .fbx generated from Marvelous Designer.Jan 22 2018, 11:15 AM