Page MenuHome
Differential D305

Bug fix T38529: Blur size can't be set to 0
AbandonedPublic
Actions

Authored by Lukas Tönne (lukastoenne) on Feb 10 2014, 10:51 PM.

Details

Reviewers
Brad Eric Hollister (brad_h)
Maniphest Tasks
T38529: Blur size can't be set to 0
Summary

Copies source to output when blur kernel is of zero dimensionality as requested.

Diff Detail

Event Timeline

Thomas Dinges (dingto) resigned from this revision.Feb 11 2014, 12:25 AM
Thomas Dinges (dingto) added a reviewer: Lukas Tönne (lukastoenne).

I am not familiar with compositor code, better let Lukas check this. :)

Lukas Tönne (lukastoenne) added a comment.Feb 12 2014, 2:38 PM

Yes, looks ok, but i would try to do this for the other blur operations too. I've checked a few of them and it looks like they all do this clamping thing.

Brad Eric Hollister (brad_h) added a comment.Feb 13 2014, 2:09 AM

Will add to other blur operations soon. Will have to be Friday / Saturday before I do so. Is this okay?

Lukas Tönne (lukastoenne) added a comment.Feb 13 2014, 11:59 AM

Thanks for your efforts, but now i've committed a fix for that bug which also solves the smooth filter size issue. Sorry if you wanted to do this yourself :)
rB51efa8a1f53f

Lukas Tönne (lukastoenne) commandeered this revision.Feb 19 2014, 9:30 AM
Lukas Tönne (lukastoenne) abandoned this revision.
Lukas Tönne (lukastoenne) edited reviewers, added: Brad Eric Hollister (brad_h); removed: Lukas Tönne (lukastoenne).

@Brad Eric Hollister (brad_h): Commandeered and closed, hope you don't mind :)

Revision Contents
Changeset List

PathSize
source/
blender/
compositor/
operations/
25 lines

Diff 949

View Options

source/blender/compositor/operations/COM_GaussianBokehBlurOperation.cpp

Loading...