Details

Reviewers

Clément Foucault (fclem)
Dalai Felinto (dfelinto)

Commits

rBSe01cadd657c7: WM: new offscreen window draw method to replace all existing methods.
rBe01cadd657c7: WM: new offscreen window draw method to replace all existing methods.

Summary

For Blender 2.8 we had to be compatible with very old OpenGL versions, and
triple buffer was designed to work without offscreen rendering, by copying
the the backbuffer to a texture right before swapping. This way we could
avoid redrawing unchanged regions by copying them from this texture on the
next redraws. Triple buffer used to suffer from poor performance and driver
bugs on specific cards, so alternative draw methods remained available.

Now that we require newer OpenGL, we can have just a single draw method
that draws into offscreen buffers, and then draws those to the screen.
This has some advantages:

Poor 3D view performance when using Region Overlap should be solved now, since we can also cache overlapping regions in offscreen buffers.
Page flip, anaglyph and interlace stereo drawing can be a little faster by avoiding a copy to an intermediate texture.
The new 3D view drawing already writes to an offscreen buffer, which we can draw from directly instead of duplicating it to another buffer.
We can remove depth and multisample buffers from the window, and instead only allocate them for the 3D view offscreen buffer. This will save some memory as well.
Windows have different OpenGL contexts, and we can't share everything between them (VAOs). With this change only minimal drawing will happen directly to the screen (cursors, gestures, borders), and so all other drawing can then happen with a single OpenGL context, see D3057.

This is a work in progress (see TODO's in the code), but posting it now
so you know this is being worked on.

Diff Detail

Repository

rB Blender

Build Status

Buildable 1197
Build 1197: arc lint + arc unit

Event Timeline

GHOST: remove support for multisample, depth, stencil and preferred swap method.

These are no longer needed by the new window manager drawing, which mainly
draws into offscreen buffers, so we can save memory. I didn't remove alpha
because it may still be useful in the future if we ever want to have
transparent windows.

Some questions:

Already in the blender2.8 branch, stereo Eevee drawing causes continuous redraws and only shows a single noisy sample. The problem is that the 3D viewport only has a single GPUViewport, which is constantly switching between the two views and resetting, so it never makes progress. Perhaps the 3D view should have a second GPUViewport for stereo drawing?
Many operators call view3d_operator_needs_opengl. It currently sets up glViewport, glScissor and matrices on the screen framebuffer, which doesn't have a depth buffer anymore. I added offscreen depth buffer drawing at some point in the past, but I need to figure out to what extent that is used now and what other kind of OpenGL drawing operators need this for. The fact that we have both new and legacy drawing code makes it difficult to understand, is there a reason we still have the legacy draw code?

As much as I'm hyped by this, I would hold my breath until we are 100% sure the offscreen contexts works on a wide set of hardware config.

I was planning to do this already before D3057 came up. I think it's a good improvement regardless if we end up drawing in a single offscreen context or not, because of the other advantages.

Idea to have 2 GPUViewport for stereo is good but they need to share the same FramebufferList and TextureList unless you want to double every offscreen texture buffers. Edit : heh forget it it wont work. You really need to duplicate everything. But byebye vram.

The old drawing path was to support other coders to work on the old viewport while we were creating the Clay & Mode engine. I don't know if it's still required. (I would personnaly say no but I don't everyone's situation).

Rebase after committing code cleanups to blender2.8.

It's indeed a lot of memory usage for stereo. Maybe there's a couple intermediate buffers that can be shared? But no easy solutions I guess.

On a 4K monitor, with multisample 4, big 3D viewport and empty scene, this patch saves quite a bit of GPU memory. (Some is already used before Blender starts).

Version	GPU Memory Usage
2.79	1768MB
2.8	1778MB
2.8 + patch	1275 MB

Update to fix all known bugs in the original patch.

A bunch of related code cleanups have already been committed.
Most of the memory usage reduction came from disabling multisample for the window, which has been committed separately.
GPUViewport (also in blender2.8) is currently creating multisample buffers, but Eevee does its own progressive sampling and Clay still looks aliased, so it seems they are not actually used? Not sure what the plan is here, but if for example Eevee will continue to do its own antialiasing we should be saving the memory.
I've left out the GHOST changes and disabling of the depth and stencil buffer from the window for now. There's still too many operators doing legacy OpenGL drawing into the backbuffer, so best leave it for another time.

GPUViewport is now managed by the window manager drawing. I'm not sure this is ideal, but we need to be able to bind/unbind and draw its color texture, and this seemed simpler than adding ARegionType methods to abstract that.
Eevee stereo drawing is now converging correctly due to storing two viewports. There is some engine data attached to the viewport, which is now duplicated as well, I'm not sure if that's a good idea or not, see TODO's in the code.

Performance seems to be the same as before, tested with Intel HD on macOS and NVIDIA Titan Xp on Linux. Tested with many editors, few editors, heavy scene, fast scene, etc. Overall this part of the drawing code is not so significant.

Harbormaster completed remote builds in B1212: Diff 10036.Feb 17 2018, 4:01 PM

Poke.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2018, 12:18 PM

Closed by commit rBe01cadd657c7: WM: new offscreen window draw method to replace all existing methods. (authored by Brecht Van Lommel (brecht)). · Explain Why

This revision was automatically updated to reflect the committed changes.

WM: new offscreen window draw method to replace existing ones.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10017

release/scripts/startup/bl_ui/space_userpref.py

source/blender/blenkernel/BKE_screen.h

source/blender/blenkernel/intern/screen.c

source/blender/blenloader/intern/readfile.c

source/blender/editors/include/BIF_glutil.h

source/blender/editors/include/ED_screen.h

source/blender/editors/interface/interface_draw.c

source/blender/editors/interface/resources.c

source/blender/editors/render/render_opengl.c

source/blender/editors/screen/area.c

source/blender/editors/screen/glutil.c

source/blender/editors/screen/screen_draw.c

source/blender/editors/screen/screen_edit.c

source/blender/editors/screen/screen_ops.c

source/blender/editors/space_image/image_draw.c

source/blender/editors/space_node/drawnode.c

source/blender/editors/space_node/node_draw.c

source/blender/editors/space_outliner/outliner_draw.c

source/blender/editors/space_view3d/space_view3d.c

source/blender/editors/space_view3d/view3d_draw.c

source/blender/editors/space_view3d/view3d_draw_legacy.c

source/blender/editors/space_view3d/view3d_intern.h

source/blender/gpu/CMakeLists.txt

source/blender/gpu/GPU_framebuffer.h

source/blender/gpu/GPU_shader.h

source/blender/gpu/GPU_viewport.h

source/blender/gpu/intern/gpu_framebuffer.c

source/blender/gpu/intern/gpu_shader.c

source/blender/gpu/intern/gpu_viewport.c

source/blender/gpu/shaders/gpu_shader_image_frag.glsl

source/blender/gpu/shaders/gpu_shader_image_interlace_frag.glsl

source/blender/gpu/shaders/gpu_shader_image_rect_modulate_alpha_frag.glsl

source/blender/makesdna/DNA_screen_types.h

source/blender/makesdna/DNA_userdef_types.h

source/blender/makesdna/DNA_windowmanager_types.h

source/blender/makesrna/intern/rna_userdef.c

source/blender/python/intern/gpu_offscreen.c

source/blender/windowmanager/WM_api.h

source/blender/windowmanager/intern/wm.c

source/blender/windowmanager/intern/wm_draw.c

source/blender/windowmanager/intern/wm_event_system.c

source/blender/windowmanager/intern/wm_stereo.c

source/blender/windowmanager/intern/wm_subwindow.c

source/blender/windowmanager/intern/wm_window.c

source/blender/windowmanager/wm.h

source/blender/windowmanager/wm_draw.h

WM: new offscreen window draw method to replace existing ones.
ClosedPublic
Actions

Revision Contents
Changeset List