Page MenuHome
Differential D3070

T45687: Rework the Export/Import of Animations
ClosedPublic
Actions

Authored by Gaia Clary (gaiaclary) on Feb 19 2018, 3:47 PM.

Details

Reviewers
Bastien Montagne (mont29)
Commits
rBSdd7b9a362d9e: T45687: Rework the Export/Import of Animations
rBdd7b9a362d9e: T45687: Rework the Export/Import of Animations
Summary

This started with a fix for an animated Object Hierarchy. Then i decided to cleanup and optimize a bit. But at the end this has become a more or less full rewrite of the Animation Exporter. All of this happened in a separate local branch and i have retained all my local commits to better see what i have done.

Brief description:

  • I fixed a few issues with exporting keyframed animations of object hierarchies where the objects have parent inverse matrices which differ from the Identity matrix.
  • I added the option to export sampled animations with a user defined sampling rate (new user interface option)
  • I briefly tested Object Animations and Rig Animations.

What is still needed:

  • Cleanup the code
  • Optimize the user interface
  • Do the Documentation

Diff Detail

Repository
rB Blender
Branch
collada (branched from master)
Build Status
Buildable 1240
Build 1240: arc lint + arc unit

Event Timeline

Gaia Clary (gaiaclary) created this revision.Feb 19 2018, 3:47 PM
Harbormaster completed remote builds in B1216: Diff 10042.Feb 19 2018, 3:47 PM
Gaia Clary (gaiaclary) mentioned this in T45687: COLLADA exports animations values for Location in world space instead of local space.Feb 19 2018, 3:50 PM
Gaia Clary (gaiaclary) updated this revision to Diff 10047.Feb 20 2018, 11:27 PM
  • Remove unneeded parameter from calc_ob_mat_at_time. also rename the function for better reading
  • added support for adjusting tangent locations during export
Gaia Clary (gaiaclary) updated this revision to Diff 10051.EditedFeb 21 2018, 4:29 PM
  • use BKE_object_matrix_local_get() to get the local transformation matrix (Many thanks to mont29 for this tip)!
  • Also created a convenience function to evaluate keyframe to make the code more readable.
Gaia Clary (gaiaclary) updated this revision to Diff 10053.Feb 21 2018, 10:59 PM
  • Added new option for baked animations (to be completed)
Gaia Clary (gaiaclary) updated this revision to Diff 10063.Feb 22 2018, 11:40 PM
  • rotation_quaternion export is not yet supported. Removing this case for now
  • Simplified the call to the evaluation function for baked animations. Also renamed the function for better reading.
  • Merge branch 'master' of git.blender.org:blender into collada
  • Use local FCurve variable instead of defining it on top of function and reusing in different places
  • simplified function call to evaluate_anim_with_constraints()
  • added support for export of sampled animations fro armatures and simple objects
  • partially revert commit 5bc2c17161cfc23ca2 that was based on a false assumption
Gaia Clary (gaiaclary) retitled this revision from T45687: fix for exporting an animated Object Hierarchy. Currently this is implemented inefficiently and the matrix evaluations are called too often. This can be made better (working on this now). to T45687: Rework the Export/Import of Animations.Feb 22 2018, 11:46 PM
Gaia Clary (gaiaclary) edited the summary of this revision. (Show Details)
Gaia Clary (gaiaclary) added a reviewer: Bastien Montagne (mont29).Feb 22 2018, 11:48 PM

Hi, Mont29

I think this is now almost good for getting back to master. I will do some more cleanup tomorrow, but if you see obvious issues, please let me know. I hope the separate commits make it clear how things have evolved so far.

cheers,
gaia

Bastien Montagne (mont29) accepted this revision.Feb 23 2018, 8:50 AM

Won’t pretend I know and understand collada code (one hellish IO format is enough for me ;) ), but I do not see anything wrong here. So indeed can go in master, if you have tested it OK :).

This revision is now accepted and ready to land.Feb 23 2018, 8:50 AM
Gaia Clary (gaiaclary) updated this revision to Diff 10067.Feb 23 2018, 3:31 PM
  • added new utility functions for later usage
  • replaced suspicious scene update function by direct call to BKE_scene_update_for_newframe()
  • added comments and function descriptions. Renamed functions for better reading
Gaia Clary (gaiaclary) updated this revision to Diff 10070.Feb 23 2018, 11:02 PM
  • Added Test environment for Collada testing with Blender. Added a test for static Mesh with different Materials and non manifold (edges without face)
Gaia Clary (gaiaclary) updated this revision to Diff 10072.Feb 24 2018, 1:17 AM
  • Add collada authoring tool string to test ignore list
Gaia Clary (gaiaclary) updated this revision to Diff 10074.Feb 24 2018, 1:12 PM
  • changed testscript to be directly called from within Blender. Before the test script was called by python, which then internally called blender with a generated script. That was not very practical
Closed by commit rBdd7b9a362d9e: T45687: Rework the Export/Import of Animations (authored by Gaia Clary (gaiaclary)). · Explain WhyFeb 24 2018, 3:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
collada/
25 lines
515 lines
1 line
1 line
1 line
2 lines
3 lines
12 lines
editors/
io/
13 lines
makesrna/
intern/
5 lines
tests/
python/
2 lines
collada/
65 lines
mesh/
144 lines

Diff 10074

View Options

source/blender/collada/AnimationExporter.h

Loading...
View Options

source/blender/collada/AnimationExporter.cpp

Loading...
View Options

source/blender/collada/AnimationImporter.cpp

Loading...
View Options

source/blender/collada/ExportSettings.h

Loading...
View Options

source/blender/collada/collada.h

Loading...
View Options

source/blender/collada/collada.cpp

Loading...
View Options

source/blender/collada/collada_utils.h

Loading...
View Options

source/blender/collada/collada_utils.cpp

Loading...
View Options

source/blender/editors/io/io_collada.c

Loading...
View Options

source/blender/makesrna/intern/rna_scene_api.c

Loading...
View Options

tests/python/CMakeLists.txt

Loading...
View Options

tests/python/collada/CMakeLists.txt

Loading...
View Options

tests/python/collada/mesh/test_mesh_simple.py

Loading...