BoltFactory addon - fixes by faerietree
AbandonedPublic
Actions

Authored by codemanx on Feb 11 2014, 2:07 AM.

Details

Reviewers: None
Maniphest Tasks: T38569: 1 bugfix, 2 minor improvements of blender-addons-contrib: LaplacianLightning & BoltFactory (4 files changed)

Summary

Minor edits to addon

https://developer.blender.org/T38569

Diff Detail

Event Timeline

Please fix problems properly.

Increased bolt size is fine I guess.

add_mesh_BoltFactory/__init__.py
21	This is a small patch, don't think it's appropriate to add as author. Edit notes belong here!
add_mesh_BoltFactory/createMesh.py
104	We have version control to track changes.
135	Missing `i` in `if`. What kind of check is this? if not bpy.context.scene.TSTEPS: should do the same. If it's supposed to test for the existence of the property, then it should probably check if hasattr(bpy.context.scene, "TSTEPS") but would prefer a real fix (cases, in which the context really needs to be accessed during registration, are rare)

I meant to say "Edit notes don't belong [in author field]"

Is there anything that runs when the addon is enabled? I really wonder why it may hit the context restriction...

Ah dude, the context restriction was in the other patch from the LaplacianLighting addon. I submitted two patches, because I had to check out two separate repositories, addons and addons-contrib.

I should have separated this into individual merge requests!! Sorry !

The LaplacianLighting is just a unbreak fix.

add_mesh_BoltFactory/__init__.py
21	Yeah, think so too. It's small, but it's useful^^ Let's drop it. I'm a open source guy. Collaboration counts, not the authors.
add_mesh_BoltFactory/createMesh.py
104	True, unfortunately I could not commit, hence no commit message, thus I was quite uncertain what to do. So I went down the detailed road. :) How best remove it, resubmit the patch - change inline? Sorry for noob question!
135	True ... will do. Thanks for detailed note! Perhaps a combination of both is best? I remember Ton shouting: "Don't touch working code!" aka "Never change a running system." Really, then I need some more time because I also would prefer tidying up the addon - unfortunately as I did neither produce the addon nor have time currently I could not dive into the functionality and was only interested to make it work being on the safe side by adding these checks without really knowing if they were required. Sorry for my rush at it! Will post back later ..