Page MenuHome
Differential D3107

Disable unused closures when baking specific types of lighting
Needs RevisionPublic
Actions

Authored by Lukas Stockner (lukasstockner97) on Mar 16 2018, 5:28 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)
Dalai Felinto (dfelinto)

Diff Detail

Repository
rB Blender
Branch
baking-disable
Build Status
Buildable 1296
Build 1296: arc lint + arc unit

Event Timeline

Lukas Stockner (lukasstockner97) created this revision.Mar 16 2018, 5:28 AM
Brecht Van Lommel (brecht) requested changes to this revision.Mar 17 2018, 4:47 PM

Seems generally fine.

intern/cycles/kernel/kernel_shader.h
830

Can we set sc->type = NBUILTIN_CLOSURES, to avoid having to check the sample weight in other places? I'd rather not use the sample weight as an indicator for the closure being enabled or not.

This revision now requires changes to proceed.Mar 17 2018, 4:47 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
2 lines
7 lines
4 lines
45 lines
split/
7 lines
svm/
1 line

Diff 10198

View Options

intern/cycles/kernel/kernel_accumulate.h

Loading...
View Options

intern/cycles/kernel/kernel_bake.h

Loading...
View Options

intern/cycles/kernel/kernel_path_branched.h

Loading...
View Options

intern/cycles/kernel/kernel_shader.h

Loading...
View Options

intern/cycles/kernel/split/kernel_branched.h

Loading...
View Options

intern/cycles/kernel/svm/svm_types.h

Loading...